Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/code_quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13', '3.14']
python-version: ['3.10', '3.11', '3.12', '3.13', '3.14']

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should fix: This PR fixes only half the Python 3.9 / ubuntu-latest breakage. .github/workflows/release_publish.yml:70-86 still runs on ubuntu-latest with python-version: '3.9' and pins virtualenv<21. The commit message says Ubuntu 26.04 has no 3.9 build for actions/setup-python, so the next release's build/publish job will fail at "Set up Python". PRs go green again, but releases stay broken.

Fix: in the same change, move the release build to a supported version such as '3.12' and drop the virtualenv<21 pin, or pin that job to an older runner image that still has 3.9. You could also drop 3.9 from the hatch.toml test matrix so local and CI matrices match.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed: release_publish.yml now sets up Python 3.10 instead of 3.9, so the release build no longer depends on a 3.9 build that ubuntu-latest lacks.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should fix: This PR fixes only half the Python 3.9 / ubuntu-latest breakage. .github/workflows/release_publish.yml:70-86 still runs on ubuntu-latest with python-version: '3.9' and pins virtualenv<21. The commit message says Ubuntu 26.04 has no 3.9 build for actions/setup-python, so the next release's build/publish job will fail at "Set up Python". PRs go green again, but releases stay broken.

Fix: in the same change, move the release build to a supported version such as '3.12' and drop the virtualenv<21 pin, or pin that job to an older runner image that still has 3.9. You could also drop 3.9 from the hatch.toml test matrix so local and CI matrices match.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed: release_publish.yml now sets up Python 3.10 instead of 3.9, so the release build no longer depends on a 3.9 build that ubuntu-latest lacks.

uses: OpenJobDescription/.github/.github/workflows/reusable_python_build.yml@mainline
with:
os: ${{ matrix.os }}
Expand Down
14 changes: 5 additions & 9 deletions .github/workflows/macos_cross_user_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ jobs:
strategy:
fail-fast: false
matrix:
# Matches code_quality.yml: requires-python is >=3.9, and the boundary
# versions are where an interpreter-specific difference in the setsid shim
# or in sys._base_executable resolution would surface.
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13', '3.14']
# Matches code_quality.yml. The boundary versions are where an
# interpreter-specific difference in the setsid shim or in
# sys._base_executable resolution would surface.
python-version: ['3.10', '3.11', '3.12', '3.13', '3.14']
steps:
- uses: actions/checkout@v7

Expand All @@ -45,11 +45,7 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Install hatch
# virtualenv 21 removed virtualenv.discovery.builtin.propose_interpreters, which
# the hatch version resolvable on 3.9 still calls, so `hatch env create` fails with
# "Environment `default` is incompatible". Pin it for 3.9 only and leave 3.10+ on
# current virtualenv. Same constraint the other workflows in this repo use.
run: pip install --upgrade hatch 'virtualenv<21; python_version < "3.10"'
run: pip install --upgrade hatch

- name: Provision, run cross-user tests, and tear down
# --keep skips the teardown: the runner is throwaway, so leaving the
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release_publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v7
with:
python-version: '3.9'
python-version: '3.10'
- name: Install dependencies
run: |
pip install --upgrade hatch "virtualenv<21"
Expand Down
Loading