Skip to content

Figure generator seeds random but includes "Ours" in default methods list #164

Description

@green-proj

Figure generator seeds random but includes "Ours" in default methods list

Severity: Low
File: backend/app/services/figure_generator.py:41

The generate_comparison_bars function accepts a seed parameter for reproducibility, but when methods is not provided, it defaults to a list with "Ours" as the first entry. The random draws for "Ours" will always appear first in the legend and may receive favorable random values due to seed interaction.

rng = random.Random(seed)

if not methods:
    methods = ["Ours", "Baseline-A", "Baseline-B", "Baseline-C", "Prior-SOTA"]
if not datasets:
    datasets = ["Dataset-1", "Dataset-2", "Dataset-3"]

Why it matters

Generated comparison charts may inadvertently bias results toward "Ours" due to deterministic seeding and list ordering, undermining scientific reproducibility claims.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions