fix: return 404 for not-found session in ideas_api.py cancel endpoint - #86
Open
hazelp343 wants to merge 1 commit into
Open
fix: return 404 for not-found session in ideas_api.py cancel endpoint#86hazelp343 wants to merge 1 commit into
hazelp343 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The
POST /sessions/{session_id}/cancelendpoint inbackend/app/modules/idea/ideas_api.pycatchesValueErrorfrom the service layer and returns 400 Bad Request for all error cases. However, the service distinguishes between two semantically different errors:Returning 400 for both conflates "invalid request" with "resource state conflict", making it harder for API clients to handle errors correctly.
Changes
Modified the exception handler in
cancel_sessionto inspect the error message and return the appropriate HTTP status code:The service layer at
backend/app/modules/idea/service.py:3337raises:ValueError("Session {id} not found")for missing sessionsValueError("Cannot cancel session in {status} state")for terminal sessionsVerification