Skip to content

Commit ea58048

Browse files
committed
fix: exception handling
1 parent 5111378 commit ea58048

1 file changed

Lines changed: 26 additions & 8 deletions

File tree

‎src/osw/core.py‎

Lines changed: 26 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1651,11 +1651,25 @@ def store_entity_(
16511651
index: int = None,
16521652
overwrite_class_param: OSW.OverwriteClassParam = None,
16531653
) -> None:
1654-
title_ = get_title(entity_)
1654+
try:
1655+
title_ = get_title(entity_)
1656+
except Exception as e:
1657+
entity_name = getattr(entity_, "name", None) or getattr(
1658+
entity_, "uuid", "unknown"
1659+
)
1660+
_logger.error(f"Error getting title for entity '{entity_name}': {e}")
1661+
return
16551662
if namespace_ is None:
16561663
namespace_ = get_namespace(entity_)
16571664
if namespace_ is None or title_ is None:
1658-
print("Error: Unsupported entity type")
1665+
entity_name = getattr(entity_, "name", None) or getattr(
1666+
entity_, "uuid", "unknown"
1667+
)
1668+
_logger.error(
1669+
f"Unsupported entity type: namespace={namespace_}, "
1670+
f"title={title_}, entity name='{entity_name}', "
1671+
f"type={type(entity_).__name__}"
1672+
)
16591673
return
16601674
if overwrite_class_param is None:
16611675
raise TypeError("'overwrite_class_param' must not be None!")
@@ -1771,12 +1785,16 @@ class UploadObject(BaseModel):
17711785
upload_index += 1
17721786

17731787
def handle_upload_object_(upload_object: UploadObject) -> None:
1774-
store_entity_(
1775-
upload_object.entity,
1776-
upload_object.namespace,
1777-
upload_object.index,
1778-
upload_object.overwrite_class_param,
1779-
)
1788+
try:
1789+
store_entity_(
1790+
upload_object.entity,
1791+
upload_object.namespace,
1792+
upload_object.index,
1793+
upload_object.overwrite_class_param,
1794+
)
1795+
except Exception as e:
1796+
entity_name = getattr(upload_object.entity, "name", None) or "unknown"
1797+
_logger.error(f"Error storing entity '{entity_name}': {e}")
17801798

17811799
if param.parallel:
17821800
_ = parallelize(

0 commit comments

Comments
 (0)