Skip to content

Commit f85586f

Browse files
committed
Removed comments that were outdated and improved typing
1 parent 647b481 commit f85586f

2 files changed

Lines changed: 6 additions & 12 deletions

File tree

‎src/osw/express.py‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,9 @@ def __init__(
9292

9393
def __init__(
9494
self,
95-
domain: str = None,
96-
cred_filepath: Union[str, Path] = None,
97-
cred_mngr: CredentialManager = None,
95+
domain: str | None = None,
96+
cred_filepath: str | Path | None = None,
97+
cred_mngr: CredentialManager | None = None,
9898
):
9999
if domain is None:
100100
if os.getenv("OSW_DOMAIN") is not None:
@@ -116,6 +116,8 @@ def __init__(
116116
# vars. A credential file is only ever READ; credentials obtained from
117117
# environment variables (OSW_USERNAME/OSW_PASSWORD, e.g. loaded from a
118118
# .env file) or an interactive prompt are kept in memory only.
119+
# Credentials can be persisted with an explicit call of
120+
# cred_mngr.save_credentials_to_file()
119121
if os.getenv("OSW_CRED_FILEPATH") is not None:
120122
cred_filepath = os.getenv("OSW_CRED_FILEPATH")
121123
elif os.getenv("OSL_CRED_FILEPATH") is not None:

‎tests/integration/conftest.py‎

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,4 @@
1-
"""Working-directory isolation for the integration tests.
2-
3-
The tests and the library defaults create files relative to the current
4-
working directory - among them credential files in CLEAR TEXT
5-
(accounts.pwd.yaml and domain-named files) and download caches
6-
(osw_files/). Running each test in its own pytest tmp dir keeps all of
7-
that out of the repository tree; pytest cleans its tmp dirs up on its
8-
own. Never rely on .gitignore for credential artifacts.
9-
"""
1+
"""Working-directory isolation for the integration tests."""
102

113
from pathlib import Path
124

0 commit comments

Comments
 (0)