Repository navigation
test: set subclass_of for oold 2 in the jsonschema tests - #225
Merged
Merged
Conversation
Contributor
Release previewMerging this PR would release v2.9.2 (current: Changelog preview (truncated)## v2.9.2 (2026-11-11)
### Bug Fixes
- Follow properties and items when collecting category templates
([#220](https://github.com/OpenSemanticLab/osw-python/pull/220),
[`55e500e`](https://github.com/OpenSemanticLab/osw-python/commit/55e500efb896f0a3d6bde98409b3a6f43a652bdc))
- Keep the stored jsonschema when store_entity regenerates it
([`9b76a8f`](https://github.com/OpenSemanticLab/osw-python/commit/9b76a8fbeb813b34c4881b54d329e9e837b08f95))
- Select category templates from the schema allOf like the wiki
([#220](https://github.com/OpenSemanticLab/osw-python/pull/220),
[`9f606f4`](https://github.com/OpenSemanticLab/osw-python/commit/9f606f48fefd640cca48e6718f1a92eca118da6b))
### Continuous Integration
- Run Main on pushes to stage and Integration on PRs into stage
([`1b55f02`](https://github.com/OpenSemanticLab/osw-python/commit/1b55f02c90cae646d690f83d6208c01f0e26e62b))
### Documentation
- State which schema references the template walk follows
([#220](https://github.com/OpenSemanticLab/osw-python/pull/220),
[`799bc07`](https://github.com/OpenSemanticLab/osw-python/commit/799bc07952aac7e6ab579bc127c5cb3000710491))
### Testing
- Drop the FileController type check, it is no longer a model
([`1eddbe8`](https://github.com/OpenSemanticLab/osw-python/commit/1eddbe867559e14806ad72eb076172cd41c7767e))
- Set subclass_of for oold 2 in the jsonschema tests
([`bd4ffdb`](https://github.com/OpenSemanticLab/osw-python/commit/bd4ffdb3e950f43f4eea0151d19d07f621eb14e0))
Preview via python-semantic-release and conventional commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing Main workflow on
stageafter the merges of #216 and #221.Changes
tests/test_store_entity_keeps_jsonschema.py:_characteristic()passessubclass_of=[CHARACTERISTIC_TYPE]instead ofsubclass_of=[].Rationale
stageatdce6069(merge of fix: keep the stored jsonschema when store_entity regenerates it #216) and8671be4(merge of fix: select category templates from the schema allOf like the wiki #221). Three tests intests/test_store_entity_keeps_jsonschema.pyraisedValueError: subclass_of is required but not setfromoold/model/v1/_descriptor.py:267.stagelocks oold 2.3.0 sinceae8cf92(refactor: take the file controllers from opensemantic.core #214). The fix: keep the stored jsonschema when store_entity regenerates it #216 branch locks oold 0.16.2, where the empty list was accepted.Tests
stage: 3 failed, 12 passed intests/test_store_entity_keeps_jsonschema.pyandtests/test_store_entity_category_templates.py.make checkpasses, andmake testreports 866 passed.