Skip to content

test: set subclass_of for oold 2 in the jsonschema tests - #225

Merged
LukasGold merged 1 commit into
stagefrom
fix/stage-oold-2-subclass-of
Nov 11, 2026
Merged

LukasGold merged 1 commit into
stagefrom
fix/stage-oold-2-subclass-of

Conversation

@LukasGold

Copy link
Copy Markdown
Contributor

Fixes the failing Main workflow on stage after the merges of #216 and #221.

Changes

  • tests/test_store_entity_keeps_jsonschema.py: _characteristic() passes subclass_of=[CHARACTERISTIC_TYPE] instead of subclass_of=[].

Rationale

Tests

  • Before the change, on stage: 3 failed, 12 passed in tests/test_store_entity_keeps_jsonschema.py and tests/test_store_entity_category_templates.py.
  • After the change: make check passes, and make test reports 866 passed.

@github-actions

Copy link
Copy Markdown
Contributor

Release preview

Merging this PR would release v2.9.2 (current: v2.9.1).

Changelog preview (truncated)
## v2.9.2 (2026-11-11)

### Bug Fixes

- Follow properties and items when collecting category templates
  ([#220](https://github.com/OpenSemanticLab/osw-python/pull/220),
  [`55e500e`](https://github.com/OpenSemanticLab/osw-python/commit/55e500efb896f0a3d6bde98409b3a6f43a652bdc))

- Keep the stored jsonschema when store_entity regenerates it
  ([`9b76a8f`](https://github.com/OpenSemanticLab/osw-python/commit/9b76a8fbeb813b34c4881b54d329e9e837b08f95))

- Select category templates from the schema allOf like the wiki
  ([#220](https://github.com/OpenSemanticLab/osw-python/pull/220),
  [`9f606f4`](https://github.com/OpenSemanticLab/osw-python/commit/9f606f48fefd640cca48e6718f1a92eca118da6b))

### Continuous Integration

- Run Main on pushes to stage and Integration on PRs into stage
  ([`1b55f02`](https://github.com/OpenSemanticLab/osw-python/commit/1b55f02c90cae646d690f83d6208c01f0e26e62b))

### Documentation

- State which schema references the template walk follows
  ([#220](https://github.com/OpenSemanticLab/osw-python/pull/220),
  [`799bc07`](https://github.com/OpenSemanticLab/osw-python/commit/799bc07952aac7e6ab579bc127c5cb3000710491))

### Testing

- Drop the FileController type check, it is no longer a model
  ([`1eddbe8`](https://github.com/OpenSemanticLab/osw-python/commit/1eddbe867559e14806ad72eb076172cd41c7767e))

- Set subclass_of for oold 2 in the jsonschema tests
  ([`bd4ffdb`](https://github.com/OpenSemanticLab/osw-python/commit/bd4ffdb3e950f43f4eea0151d19d07f621eb14e0))

Preview via python-semantic-release and conventional commits.

@LukasGold
LukasGold merged commit 12ecbdd into stage Nov 11, 2026
12 checks passed
@LukasGold
LukasGold deleted the fix/stage-oold-2-subclass-of branch November 11, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant