Skip to content

Commit 8b0c6bc

Browse files
authored
Merge pull request #314 from OpenSourceAWE/agent/BeyondTheSim.jl-17
Fit the contour generate_airfoils is handed, not a second wrap of it
2 parents 9e7e320 + d86811a commit 8b0c6bc

2 files changed

Lines changed: 7 additions & 8 deletions

File tree

CHANGELOG.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,12 @@
99
own `_d<degrees>.dat` filename tag instead of the `delta_suffix` one the files were
1010
written under, which spells a minus sign `m` and a decimal point `p`, so
1111
`delta=-10` or `delta=2.5` found no `.dat` and drew nothing.
12+
- `generate_airfoils` fits the contour it is handed rather than shrink-wrapping it a
13+
second time. Both adapters wrap before they call, with the `wrap_method` their
14+
settings name, so the second wrap discarded that setting and degenerated the Kulfan
15+
fit: on the SK100's 45 mesh sections nine came out with `.dat` coordinates at 1e2 to
16+
1e4 instead of 0..1, and any consumer mapping the mesh onto a structure rejected the
17+
geometry.
1218

1319
## VortexStepMethod v5.1.0 2026-09-11
1420

@@ -29,12 +35,6 @@
2935

3036
### Fixed
3137

32-
- `generate_airfoils` fits the contour it is handed rather than shrink-wrapping it a
33-
second time. Both adapters wrap before they call, with the `wrap_method` their
34-
settings name, so the second wrap discarded that setting and degenerated the Kulfan
35-
fit: on the SK100's 45 mesh sections nine came out with `.dat` coordinates at 1e2 to
36-
1e4 instead of 0..1, and any consumer mapping the mesh onto a structure rejected the
37-
geometry.
3838
- The `NONLIN` solver backtracks along each Newton step instead of always taking
3939
it whole, so it converges past stall where the full step used to cycle: on the
4040
`test/solver/solver_test_wing.yaml` wing at 26.6° it stopped 3.6% below `LOOP`'s

test/airfoil_aero/test_airfoil_aero.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -283,8 +283,7 @@ end
283283
aero_solver=NeuralFoilSolver(model_size="medium"), verbose=false)
284284
@test ok == [1]
285285
_, written_y = read_dat_coords(joinpath(out, "airfoils", "1.dat"))
286-
# A second shrink wrap inflates the section by its own clearance, 0.006, which is
287-
# three orders of magnitude above the resampling error this tolerance allows.
286+
# A second shrink wrap inflates the section by its clearance, 0.006 — 60x this bound.
288287
@test maximum(abs, collect(extrema(written_y)) .-
289288
collect(extrema(fitted_y))) < 1e-4
290289
end

0 commit comments

Comments
 (0)