Skip to content

Commit 9ed3cd6

Browse files
authored
Merge pull request #375 from OpenSourceAWE/changelog/va-naming-rule
Explain the va naming rule in the changelog instead of listing every rename
2 parents 46adf3d + ca7db91 commit 9ed3cd6

1 file changed

Lines changed: 11 additions & 13 deletions

File tree

CHANGELOG.md

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -38,19 +38,17 @@
3838
- BREAKING: `ObjAdapter.center_to_com!`, `calculate_inertia_tensor` and
3939
`calc_inertia_y_rotation` are removed. Mesh mass properties are computed by
4040
SymbolicAWEModels, which reads the mesh with `read_faces`.
41-
- BREAKING: the apparent wind is `va` for the speed [m/s], `va_vec` for the 3-vector and
42-
`va_dist` / `va_vec_dist` per panel, and the old names error:
43-
- `body_aero.va` becomes `body_aero.va_vec`, and `va=` becomes `va_vec=` in
44-
`BodyAerodynamics(...)` and `reinit!`.
45-
- `Panel.va` becomes `Panel.va_vec`, and `SemiInfiniteFilament.vel_mag` becomes `va`.
46-
- On `VSMSolution`, `_va_dist` becomes `va_vec_dist` and `va_unrefined_dist` becomes
47-
`va_vec_unrefined_dist`.
48-
- `v_a_dist` on `BodyAerodynamics` and `solver.lr` becomes `v_rel_dist`, and
49-
`solver.br.va_norm_dist` becomes `va_dist`.
50-
- The `linearize` keyword `va_idxs` becomes `va_vec_idxs`, the `calculate_results` key
51-
`"va_ref"` becomes `"va_ref_vec"`, and the `plot_polars` / `plot_combined_analysis`
52-
keyword `v_a` becomes `va`.
53-
- The settings keys `condition.wind_speed` and `airfoil.v_app` become `va`.
41+
- BREAKING: the apparent wind follows one naming rule. `va` is its speed [m/s], a `_vec`
42+
suffix makes it the 3-vector [m/s] in the body frame, and a `_dist` suffix gives one
43+
value per panel, so `va_vec_dist` is a 3-vector per panel. `v_rel` is the local flow a
44+
panel sees, induced velocity included. Public names that break:
45+
`body_aero.va` and the `va=` keyword of `BodyAerodynamics` and `reinit!` (now
46+
`va_vec`), `VSMSolution._va_dist` and `va_unrefined_dist` (now `va_vec_dist` and
47+
`va_vec_unrefined_dist`), `BodyAerodynamics.v_a_dist` (now `v_rel_dist`), the
48+
`linearize` keyword `va_idxs` (now `va_vec_idxs`), the `calculate_results` key
49+
`"va_ref"` (now `"va_ref_vec"`), the `v_a` keyword of `plot_polars` and
50+
`plot_combined_analysis` (now `va`), and the settings keys `condition.wind_speed` and
51+
`airfoil.v_app` (now `va`). The old names raise an error.
5452
- Requires Julia 1.12 or 1.13; 1.10 and 1.11 keep resolving v5.1.1.
5553
- The Makie `plot!` methods for a `Panel` or a `BodyAerodynamics` return a
5654
`Vector{Makie.AbstractPlot}` instead of a `Vector{Any}`; for a `BodyAerodynamics`

0 commit comments

Comments
 (0)