Since #372, write_polar_csv and write_polar_matrix_csv write Arrow for an .arrow path, and the geometry YAML key csv_file_path can point at an .arrow polar. The _csv in all three names is now wrong.
All three are public: the two writers are exported, and csv_file_path is part of the geometry YAML schema that BeyondTheSim and other downstream datasets carry. Renaming them is a breaking change, so it is a decision rather than a cleanup.
What I would do: rename the writers to write_polar / write_polar_matrix and the key to polar_file_path. The old writer names would error with a pointer to the new ones. The YAML loader would read csv_file_path as a deprecated alias for one release, so existing datasets keep loading.
Since #372,
write_polar_csvandwrite_polar_matrix_csvwrite Arrow for an.arrowpath, and the geometry YAML keycsv_file_pathcan point at an.arrowpolar. The_csvin all three names is now wrong.All three are public: the two writers are exported, and
csv_file_pathis part of the geometry YAML schema that BeyondTheSim and other downstream datasets carry. Renaming them is a breaking change, so it is a decision rather than a cleanup.What I would do: rename the writers to
write_polar/write_polar_matrixand the key topolar_file_path. The old writer names would error with a pointer to the new ones. The YAML loader would readcsv_file_pathas a deprecated alias for one release, so existing datasets keep loading.