Conversation
…r V3 Kite, and adjusting plotting script to handle arbitrary column sorting of literature input
…indTunnel Data and Python
…xstepmethodjl-and-run-on-a-simple-wing' of github.com:OpenSourceAWE/VortexStepMethod.jl into 183-create-a-load_geometry_from_yaml-function-for-vortexstepmethodjl-and-run-on-a-simple-wing
…n-for-vortexstepmethodjl-and-run-on-a-simple-wing
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a YAML-based geometry loading function for VortexStepMethod.jl by updating configuration files and adding required dependencies. The change simplifies the geometry file structure by removing bridle-related data and updates the reference to use a cleaner geometry file.
- Updated geometry file reference in VSM settings from wing_geometry_polars_CFD.yaml to aero_geometry.yaml
- Cleaned up aero_geometry.yaml by removing bridle nodes, lines, and connections data
- Added YAML and PrettyTables dependencies to the manifest
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| data/TUDELFT_V3_KITE/vsm_settings.yaml | Updated geometry file reference to point to simplified aero_geometry.yaml |
| data/TUDELFT_V3_KITE/aero_geometry.yaml | Removed bridle-related configuration data, keeping only wing airfoil definitions |
| Manifest-v1.11.toml.default | Added YAML and PrettyTables package dependencies for geometry loading functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1-Bart-1
reviewed
Oct 7, 2025
| wings: | ||
| - name: V3_Kite # Wing identifier for output labeling | ||
| geometry_file: data/TUDELFT_V3_KITE/wing_geometry_polars_CFD.yaml | ||
| geometry_file: data/TUDELFT_V3_KITE/aero_geometry.yaml |
Member
There was a problem hiding this comment.
I would remove the "data" prefix, all yaml files are in the data dir
Member
There was a problem hiding this comment.
But I will still approve this PR, as this is not important
1-Bart-1
approved these changes
Oct 7, 2025
1-Bart-1
added a commit
that referenced
this pull request
Jul 1, 2026
…and run on a simple wing (#200) * adding a pyramid_model, initial commit * #183 testing commit * #185, this commit/issue number work? * #185 Create rectangular wing from yaml and plot, using csv polar input * #185 added yaml_geometry: enabling one to run VSM defined from a yaml file. * #185 V3 kite runs, but results are yet not accurate * #185 setting standard printing to false, adding literature results for V3 Kite, and adjusting plotting script to handle arbitrary column sorting of literature input * #185 non-italic subscripts in plotting * #185 , #186 : cleaned-up yaml_geometry, added a comparison to CFD - WindTunnel Data and Python * #155 V3_kite example now creates wing and solver from VSMSettings * #155 adjusted V3_kite, to be specified from a .yaml * #155 working, with Wing constructor * #155 #185 added StructMapping for yaml parsing * #185 #155 created ram_air_kite folder, all tests passing * #185 adding a working pyramid model example * #185, #186 added test_yaml_geometry * #186 working on test folder * #186 passing all tests now! * # 186 Adding random to toml * Update manifest * More versions * #186 test passing without errors/warnings * #186 attempt at resolving windows issues * Update docstring * Remove unused files * #186 updated NEWS.md * #196 adding aero_geometry yaml * Update Manifest-v1.11.toml.default Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update Manifest-v1.11.toml.default Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: 1-Bart-1 <bart@vandelint.net> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.