OP#10404: Refuse geo-only track files without a declared CRS

A missing CRS used to fall back to EPSG:25833 with a warning, which shifts every road user silently if the guess is wrong. The parser now raises MissingGeoCoordinatesCrs for a missing or blank CRS and the fallback constant is gone.

Author: randy-seng

OTAnalytics/application/orthophoto.py

@@ -18,10 +18,6 @@
 from OTAnalytics.domain.track_repository import TrackRepository
 from OTAnalytics.domain.video import VideoRepository
 
-# The CRS OTFusion's default geo offset shifts local world coordinates into.
-# Files written before OTFusion declared its CRS (OTCloud OP#10404) are assumed
-# to be in it.
-FALLBACK_GEO_CRS = "EPSG:25833"
 ORTHOPHOTO_REQUIRED = (
     "These track files place road users only by geo coordinates, so they need an"
     " orthophoto to be shown and counted. Nothing was loaded."

OTAnalytics/domain/orthophoto.py

@@ -35,6 +35,10 @@ class MixedTrackFiles(OrthophotoError):
     """Camera Track Files were loaded into a project that shows an Orthophoto."""
 
 
+class MissingGeoCoordinatesCrs(OrthophotoError):
+    """A Geo-only Track File does not say which CRS its geo coordinates are in."""
+
+
 class OrthophotoNotFound(OrthophotoError):
     """The Orthophoto the project declares cannot be obtained."""
 

OTAnalytics/plugin_parser/feathers_parser.py

@@ -12,9 +12,7 @@
 import polars as pl
 
 import OTAnalytics.plugin_parser.ottrk_dataformat as ottrk_format
-from OTAnalytics.application.logger import logger
 from OTAnalytics.application.orthophoto import (
-    FALLBACK_GEO_CRS,
     NoOrthophotoGeoreference,
     ProvideOrthophotoGeoreference,
 )
@@ -25,7 +23,7 @@
 )
 from OTAnalytics.domain import track
 from OTAnalytics.domain.georeference import GeoreferenceMetadata, geo_to_pixel_transform
-from OTAnalytics.domain.orthophoto import MixedTrackFiles
+from OTAnalytics.domain.orthophoto import MissingGeoCoordinatesCrs, MixedTrackFiles
 from OTAnalytics.domain.track_dataset.track_dataset import TrackDataset
 from OTAnalytics.domain.video import VideoMetadata
 from OTAnalytics.plugin_datastore.polars_track_store import (
@@ -55,6 +53,11 @@
     " geo coordinates only (OTFusion output) and {camera} come with their own"
     " video. Load them in separate projects. Nothing was loaded."
 )
+MISSING_GEO_COORDINATES_CRS = (
+    "'{file}' does not say which CRS its geo coordinates are in, so it cannot be"
+    " placed on the orthophoto. Export it again with a current OTFusion."
+    " Nothing was loaded."
+)
 
 
 def place_on_orthophoto(
@@ -177,13 +180,12 @@ def parse(self, file: Path) -> TrackParseResult:
         )
 
     def _geo_coordinates_crs(self, metadata: dict, file: Path) -> str:
-        if (crs := self.parse_geo_coordinates_crs(metadata)) is not None:
-            return crs
-        logger().warning(
-            f"'{file.name}' does not say which CRS its geo coordinates are in."
-            f" Assuming {FALLBACK_GEO_CRS}."
-        )
-        return FALLBACK_GEO_CRS
+        crs = self.parse_geo_coordinates_crs(metadata)
+        if crs is None or not crs.strip():
+            raise MissingGeoCoordinatesCrs(
+                MISSING_GEO_COORDINATES_CRS.format(file=file.name)
+            )
+        return crs
 
     def _parse_video_metadata(self, metadata: dict) -> VideoMetadata:
         """

tests/unit/OTAnalytics/plugin_parser/test_feathers_parser.py

@@ -16,17 +16,18 @@
 from pytest import approx
 
 import OTAnalytics.plugin_parser.ottrk_dataformat as ottrk_format
-from OTAnalytics.application.orthophoto import (
-    FALLBACK_GEO_CRS,
-    ProvideOrthophotoGeoreference,
-)
+from OTAnalytics.application.orthophoto import ProvideOrthophotoGeoreference
 from OTAnalytics.application.parser.track_parser import (
     DetectionMetadata,
     TrackParseResult,
 )
 from OTAnalytics.domain import track
 from OTAnalytics.domain.georeference import GeoreferenceMetadata
-from OTAnalytics.domain.orthophoto import MixedTrackFiles, OrthophotoRequired
+from OTAnalytics.domain.orthophoto import (
+    MissingGeoCoordinatesCrs,
+    MixedTrackFiles,
+    OrthophotoRequired,
+)
 from OTAnalytics.domain.track_dataset.track_dataset import (
     IncompatibleGeoreferenceMetadataError,
 )
@@ -672,17 +673,34 @@ def test_asks_for_the_mapping_in_the_declared_crs(
 
         given.orthophoto_georeference.for_crs.assert_called_once_with(GEO_ONLY_CRS)
 
-    def test_falls_back_to_default_crs_when_none_is_declared(
-        self, test_data_tmp_dir: Path
+    def test_refuses_when_no_crs_is_declared(self, test_data_tmp_dir: Path) -> None:
+        given = setup_default_geo_only(
+            create_given_geo_only(test_data_tmp_dir), declares_crs=False
+        )
+        target = create_target_geo_only(given)
+
+        with pytest.raises(MissingGeoCoordinatesCrs, match=given.feather_file.name):
+            target.parse(given.feather_file)
+
+        given.orthophoto_georeference.for_crs.assert_not_called()
+
+    @pytest.mark.parametrize("blank_crs", ["", "   ", None])
+    def test_refuses_when_the_declared_crs_is_blank(
+        self, test_data_tmp_dir: Path, blank_crs: str | None
     ) -> None:
         given = setup_default_geo_only(
             create_given_geo_only(test_data_tmp_dir), declares_crs=False
         )
+        sidecar_file = given.tmp_dir / "fusion_metadata.json"
+        sidecar = json.loads(sidecar_file.read_text())
+        sidecar[ottrk_format.GEO_COORDINATES] = {ottrk_format.CRS: blank_crs}
+        sidecar_file.write_text(json.dumps(sidecar))
         target = create_target_geo_only(given)
 
-        target.parse(given.feather_file)
+        with pytest.raises(MissingGeoCoordinatesCrs):
+            target.parse(given.feather_file)
 
-        given.orthophoto_georeference.for_crs.assert_called_once_with(FALLBACK_GEO_CRS)
+        given.orthophoto_georeference.for_crs.assert_not_called()
 
     def test_places_detections_outside_the_orthophoto_without_clipping(
         self, test_data_tmp_dir: Path