Mark the project as unsaved when the analysis config changes

Publish every change of a single analysis setting through a
StaticAnalysisConfigChanged notifier and let the quick save button
observe it. Loading a project replaces the whole configuration without
passing the notifier, so a load is not mistaken for an unsaved change.

Fix the quick save button of the webui along the way: writing to the
style dict never reached the browser, because only calling props or
style schedules the update. Restore the color the button was built with
instead of removing the prop, which would render the button white.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: schubsen

OTAnalytics/application/use_cases/static_analysis_config.py

@@ -9,6 +9,31 @@
     CurrentExportConfigState,
     CurrentStaticAnalysisConfigState,
 )
+from OTAnalytics.domain.observer import OBSERVER, Subject
+
+
+class StaticAnalysisConfigChanged:
+    """Notify observers that a value of the static analysis config was changed.
+
+    Only changes made by the user are published. Loading a project replaces the
+    whole configuration without passing this notifier, so a load does not look
+    like an unsaved change.
+    """
+
+    def __init__(self) -> None:
+        self._subject = Subject[None]()
+
+    def register(self, observer: OBSERVER[None]) -> None:
+        """Listen to changes of the static analysis config.
+
+        Args:
+            observer (OBSERVER[None]): the observer to be registered.
+        """
+        self._subject.register(observer)
+
+    def notify(self) -> None:
+        """Notify all observers about a changed static analysis config."""
+        self._subject.notify(None)
 
 
 class GetDoEventsOfCurrentAnalysisConfig:
@@ -37,10 +62,17 @@ class SetDoEventsInCurrentAnalysisConfig:
     Args:
         state (CurrentStaticAnalysisConfigState): the state holding the analysis
             settings.
+        config_changed (StaticAnalysisConfigChanged): notifies observers about
+            the change.
     """
 
-    def __init__(self, state: CurrentStaticAnalysisConfigState) -> None:
+    def __init__(
+        self,
+        state: CurrentStaticAnalysisConfigState,
+        config_changed: StaticAnalysisConfigChanged,
+    ) -> None:
         self._state = state
+        self._config_changed = config_changed
 
     def set(self, do_events: bool) -> None:
         """Set whether events are to be detected.
@@ -49,6 +81,7 @@ def set(self, do_events: bool) -> None:
             do_events (bool): True if events are to be detected.
         """
         self._state.do_events = do_events
+        self._config_changed.notify()
 
 
 class GetDoCountingOfCurrentAnalysisConfig:
@@ -77,10 +110,17 @@ class SetDoCountingInCurrentAnalysisConfig:
     Args:
         state (CurrentStaticAnalysisConfigState): the state holding the analysis
             settings.
+        config_changed (StaticAnalysisConfigChanged): notifies observers about
+            the change.
     """
 
-    def __init__(self, state: CurrentStaticAnalysisConfigState) -> None:
+    def __init__(
+        self,
+        state: CurrentStaticAnalysisConfigState,
+        config_changed: StaticAnalysisConfigChanged,
+    ) -> None:
         self._state = state
+        self._config_changed = config_changed
 
     def set(self, do_counting: bool) -> None:
         """Set whether counts are to be created.
@@ -89,6 +129,7 @@ def set(self, do_counting: bool) -> None:
             do_counting (bool): True if counts are to be created.
         """
         self._state.do_counting = do_counting
+        self._config_changed.notify()
 
 
 class GetNumProcessesOfCurrentAnalysisConfig:
@@ -117,10 +158,17 @@ class SetNumProcessesInCurrentAnalysisConfig:
     Args:
         state (CurrentStaticAnalysisConfigState): the state holding the analysis
             settings.
+        config_changed (StaticAnalysisConfigChanged): notifies observers about
+            the change.
     """
 
-    def __init__(self, state: CurrentStaticAnalysisConfigState) -> None:
+    def __init__(
+        self,
+        state: CurrentStaticAnalysisConfigState,
+        config_changed: StaticAnalysisConfigChanged,
+    ) -> None:
         self._state = state
+        self._config_changed = config_changed
 
     def set(self, num_processes: int) -> None:
         """Set the number of processes to be used for the analysis.
@@ -129,6 +177,7 @@ def set(self, num_processes: int) -> None:
             num_processes (int): the number of processes.
         """
         self._state.num_processes = num_processes
+        self._config_changed.notify()
 
 
 class GetLogfileOfCurrentAnalysisConfig:
@@ -157,10 +206,17 @@ class SetLogfileInCurrentAnalysisConfig:
     Args:
         state (CurrentStaticAnalysisConfigState): the state holding the analysis
             settings.
+        config_changed (StaticAnalysisConfigChanged): notifies observers about
+            the change.
     """
 
-    def __init__(self, state: CurrentStaticAnalysisConfigState) -> None:
+    def __init__(
+        self,
+        state: CurrentStaticAnalysisConfigState,
+        config_changed: StaticAnalysisConfigChanged,
+    ) -> None:
         self._state = state
+        self._config_changed = config_changed
 
     def set(self, logfile: Path) -> None:
         """Set the logfile the analysis log is written to.
@@ -169,6 +225,7 @@ def set(self, logfile: Path) -> None:
             logfile (Path): the logfile.
         """
         self._state.logfile = logfile
+        self._config_changed.notify()
 
 
 class GetSaveNameOfCurrentAnalysisConfig:
@@ -195,10 +252,17 @@ class SetSaveNameInCurrentAnalysisConfig:
 
     Args:
         state (CurrentExportConfigState): the state holding the export settings.
+        config_changed (StaticAnalysisConfigChanged): notifies observers about
+            the change.
     """
 
-    def __init__(self, state: CurrentExportConfigState) -> None:
+    def __init__(
+        self,
+        state: CurrentExportConfigState,
+        config_changed: StaticAnalysisConfigChanged,
+    ) -> None:
         self._state = state
+        self._config_changed = config_changed
 
     def set(self, save_name: str) -> None:
         """Set the name used to save analysis results.
@@ -207,6 +271,7 @@ def set(self, save_name: str) -> None:
             save_name (str): the save name.
         """
         self._state.save_name = save_name
+        self._config_changed.notify()
 
 
 class GetSaveSuffixOfCurrentAnalysisConfig:
@@ -233,10 +298,17 @@ class SetSaveSuffixInCurrentAnalysisConfig:
 
     Args:
         state (CurrentExportConfigState): the state holding the export settings.
+        config_changed (StaticAnalysisConfigChanged): notifies observers about
+            the change.
     """
 
-    def __init__(self, state: CurrentExportConfigState) -> None:
+    def __init__(
+        self,
+        state: CurrentExportConfigState,
+        config_changed: StaticAnalysisConfigChanged,
+    ) -> None:
         self._state = state
+        self._config_changed = config_changed
 
     def set(self, save_suffix: str) -> None:
         """Set the suffix appended to the save name.
@@ -245,6 +317,7 @@ def set(self, save_suffix: str) -> None:
             save_suffix (str): the save suffix.
         """
         self._state.save_suffix = save_suffix
+        self._config_changed.notify()
 
 
 class GetEventFormatsOfCurrentAnalysisConfig:
@@ -271,10 +344,17 @@ class SetEventFormatsInCurrentAnalysisConfig:
 
     Args:
         state (CurrentExportConfigState): the state holding the export settings.
+        config_changed (StaticAnalysisConfigChanged): notifies observers about
+            the change.
     """
 
-    def __init__(self, state: CurrentExportConfigState) -> None:
+    def __init__(
+        self,
+        state: CurrentExportConfigState,
+        config_changed: StaticAnalysisConfigChanged,
+    ) -> None:
         self._state = state
+        self._config_changed = config_changed
 
     def set(self, event_formats: set[str]) -> None:
         """Set the formats the event list is exported to.
@@ -283,6 +363,7 @@ def set(self, event_formats: set[str]) -> None:
             event_formats (set[str]): the event formats.
         """
         self._state.event_formats = event_formats
+        self._config_changed.notify()
 
 
 class GetCountIntervalsOfCurrentAnalysisConfig:
@@ -309,10 +390,17 @@ class SetCountIntervalsInCurrentAnalysisConfig:
 
     Args:
         state (CurrentExportConfigState): the state holding the export settings.
+        config_changed (StaticAnalysisConfigChanged): notifies observers about
+            the change.
     """
 
-    def __init__(self, state: CurrentExportConfigState) -> None:
+    def __init__(
+        self,
+        state: CurrentExportConfigState,
+        config_changed: StaticAnalysisConfigChanged,
+    ) -> None:
         self._state = state
+        self._config_changed = config_changed
 
     def set(self, count_intervals: set[int]) -> None:
         """Set the count intervals in minutes.
@@ -321,6 +409,7 @@ def set(self, count_intervals: set[int]) -> None:
             count_intervals (set[int]): the count intervals in minutes.
         """
         self._state.count_intervals = count_intervals
+        self._config_changed.notify()
 
 
 class GetCountingEventOfCurrentAnalysisConfig:
@@ -347,10 +436,17 @@ class SetCountingEventInCurrentAnalysisConfig:
 
     Args:
         state (CurrentExportConfigState): the state holding the export settings.
+        config_changed (StaticAnalysisConfigChanged): notifies observers about
+            the change.
     """
 
-    def __init__(self, state: CurrentExportConfigState) -> None:
+    def __init__(
+        self,
+        state: CurrentExportConfigState,
+        config_changed: StaticAnalysisConfigChanged,
+    ) -> None:
         self._state = state
+        self._config_changed = config_changed
 
     def set(self, counting_event: CountingEvent) -> None:
         """Set the event a road user is counted at.
@@ -359,3 +455,4 @@ def set(self, counting_event: CountingEvent) -> None:
             counting_event (CountingEvent): the counting event.
         """
         self._state.counting_event = counting_event
+        self._config_changed.notify()

OTAnalytics/plugin_ui/base_application.py

@@ -165,6 +165,9 @@
     RemoveSection,
 )
 from OTAnalytics.application.use_cases.start_new_project import StartNewProject
+from OTAnalytics.application.use_cases.static_analysis_config import (
+    StaticAnalysisConfigChanged,
+)
 from OTAnalytics.application.use_cases.suggest_save_path import SavePathSuggester
 from OTAnalytics.application.use_cases.track_repository import (
     AddAllTracks,
@@ -476,6 +479,15 @@ def current_key_prefix(self) -> CurrentKeyPrefix:
     def current_static_analysis_config_state(self) -> CurrentStaticAnalysisConfigState:
         return CurrentStaticAnalysisConfigState()
 
+    @cached_property
+    def static_analysis_config_changed(self) -> StaticAnalysisConfigChanged:
+        """One notifier for the whole application.
+
+        Every use case changing a single analysis setting publishes here, so
+        observers do not have to know which setting was changed.
+        """
+        return StaticAnalysisConfigChanged()
+
     @cached_property
     def get_current_remark(self) -> GetCurrentRemark:
         return GetCurrentRemark(self.remark_repository)

OTAnalytics/plugin_ui/gui_application.py

@@ -117,6 +117,9 @@ def register_observers(self) -> None:
         self.load_otconfig.register(self.view_model.update_remark_view)
         self.project_updater.register(self.view_model.update_quick_save_button)
         self.track_file_repository.register(self.view_model.update_quick_save_button)
+        self.static_analysis_config_changed.register(
+            self.view_model.update_quick_save_button
+        )
         self.project_updater.register(self.view_model.show_current_project)
         self.project_updater.register(self.view_model.update_svz_metadata_view)
         layer_groups, layers = self.layers

OTAnalytics/plugin_ui/nicegui_application.py

@@ -265,42 +265,53 @@ def project_form(self) -> ProjectForm:
     def static_analysis_config_form(self) -> StaticAnalysisConfigForm:
         analysis_config_state = self.current_static_analysis_config_state
         export_config_state = analysis_config_state.export_config
+        config_changed = self.static_analysis_config_changed
         return StaticAnalysisConfigForm(
             resource_manager=self.resource_manager,
             get_do_events=GetDoEventsOfCurrentAnalysisConfig(analysis_config_state),
-            set_do_events=SetDoEventsInCurrentAnalysisConfig(analysis_config_state),
+            set_do_events=SetDoEventsInCurrentAnalysisConfig(
+                analysis_config_state, config_changed
+            ),
             get_do_counting=GetDoCountingOfCurrentAnalysisConfig(analysis_config_state),
-            set_do_counting=SetDoCountingInCurrentAnalysisConfig(analysis_config_state),
+            set_do_counting=SetDoCountingInCurrentAnalysisConfig(
+                analysis_config_state, config_changed
+            ),
             get_save_name=GetSaveNameOfCurrentAnalysisConfig(export_config_state),
-            set_save_name=SetSaveNameInCurrentAnalysisConfig(export_config_state),
+            set_save_name=SetSaveNameInCurrentAnalysisConfig(
+                export_config_state, config_changed
+            ),
             get_save_suffix=GetSaveSuffixOfCurrentAnalysisConfig(export_config_state),
-            set_save_suffix=SetSaveSuffixInCurrentAnalysisConfig(export_config_state),
+            set_save_suffix=SetSaveSuffixInCurrentAnalysisConfig(
+                export_config_state, config_changed
+            ),
             get_event_formats=GetEventFormatsOfCurrentAnalysisConfig(
                 export_config_state
             ),
             set_event_formats=SetEventFormatsInCurrentAnalysisConfig(
-                export_config_state
+                export_config_state, config_changed
             ),
             get_count_intervals=GetCountIntervalsOfCurrentAnalysisConfig(
                 export_config_state
             ),
             set_count_intervals=SetCountIntervalsInCurrentAnalysisConfig(
-                export_config_state
+                export_config_state, config_changed
             ),
             get_counting_event=GetCountingEventOfCurrentAnalysisConfig(
                 export_config_state
             ),
             set_counting_event=SetCountingEventInCurrentAnalysisConfig(
-                export_config_state
+                export_config_state, config_changed
             ),
             get_num_processes=GetNumProcessesOfCurrentAnalysisConfig(
                 analysis_config_state
             ),
             set_num_processes=SetNumProcessesInCurrentAnalysisConfig(
-                analysis_config_state
+                analysis_config_state, config_changed
             ),
             get_logfile=GetLogfileOfCurrentAnalysisConfig(analysis_config_state),
-            set_logfile=SetLogfileInCurrentAnalysisConfig(analysis_config_state),
+            set_logfile=SetLogfileInCurrentAnalysisConfig(
+                analysis_config_state, config_changed
+            ),
         )
 
     @cached_property