OP#10404: Replace get_all calls with is_empty in orthophoto logic and tests

Author: randy-seng

OTAnalytics/application/orthophoto.py

@@ -206,9 +206,9 @@ def choose(self, file: Path) -> None:
 
     def _has_sections_tracks_or_videos(self) -> bool:
         return (
-            bool(self._section_repository.get_all())
-            or not self._track_repository.get_all().empty
-            or bool(self._video_repository.get_all())
+            not self._section_repository.is_empty()
+            or not self._track_repository.is_empty()
+            or not self._video_repository.is_empty()
         )
 
 

tests/unit/OTAnalytics/application/test_orthophoto.py

@@ -105,24 +105,24 @@ def create_given_choose() -> GivenChoose:
 
 
 def setup_default_choose(given: GivenChoose) -> GivenChoose:
-    given.section_repository.get_all.return_value = []
-    given.track_repository.get_all.return_value.empty = True
-    given.video_repository.get_all.return_value = []
+    given.section_repository.is_empty.return_value = True
+    given.track_repository.is_empty.return_value = True
+    given.video_repository.is_empty.return_value = True
     return given
 
 
 def setup_with_sections(given: GivenChoose) -> GivenChoose:
-    given.section_repository.get_all.return_value = [Mock()]
+    given.section_repository.is_empty.return_value = False
     return given
 
 
 def setup_with_tracks(given: GivenChoose) -> GivenChoose:
-    given.track_repository.get_all.return_value.empty = False
+    given.track_repository.is_empty.return_value = False
     return given
 
 
 def setup_with_videos(given: GivenChoose) -> GivenChoose:
-    given.video_repository.get_all.return_value = [Mock()]
+    given.video_repository.is_empty.return_value = False
     return given