Fix class filter dialog selection in WebUI

The dialog never rendered its checkboxes, bound every checkbox to the
last class created in the loop and always started from all classes, so
"Apply" also passed classes that were not selected.

Move the dialog into FilterClassificationForm, which derives its state
from the current class filter selection (all classes if there is none,
as in the customtkinter GUI), binds each checkbox to its own class and
evaluates the checkbox value instead of toggling. Buttons are built in a
dedicated method so further buttons can be added easily.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: briemla

OTAnalytics/plugin_ui/nicegui_gui/pages/visualization_filters_form/container.py

@@ -1,3 +1,5 @@
+from typing import Callable
+
 from nicegui import ui
 from nicegui.elements.button import Button
 from nicegui.events import ValueChangeEventArguments
@@ -140,6 +142,68 @@ def _on_reset_button_clicked(self) -> None:
         self._dialog.close()
 
 
+class FilterClassificationForm:
+    """Dialog to select the classes whose tracks are shown.
+
+    The checkboxes show the current class filter selection. Without a selection,
+    every class counts as selected, as in the customtkinter GUI.
+    """
+
+    def __init__(self, viewmodel: ViewModel) -> None:
+        self._viewmodel = viewmodel
+        self._classes: list[str] = []
+        self._selected_classes: set[str] = set()
+
+    def open(self) -> None:
+        self._classes = self._viewmodel.get_classes()
+        self._selected_classes = set(self._current_selection())
+        with ui.dialog() as self._dialog, ui.card():
+            for classification in self._classes:
+                self._build_checkbox(classification)
+            with ui.row():
+                self._build_buttons()
+        self._dialog.open()
+
+    def _current_selection(self) -> list[str]:
+        selection = self._viewmodel.get_class_filter_selection()
+        return self._classes if selection is None else selection
+
+    def _build_checkbox(self, classification: str) -> None:
+        FormFieldCheckbox(
+            label_text=classification,
+            initial_value=classification in self._selected_classes,
+            on_value_change=self._create_class_toggle(classification),
+        ).build()
+
+    def _create_class_toggle(
+        self, classification: str
+    ) -> Callable[[ValueChangeEventArguments], None]:
+        def toggle(event: ValueChangeEventArguments) -> None:
+            self._select_class(classification, event.value)
+
+        return toggle
+
+    def _build_buttons(self) -> None:
+        ui.button("Apply", on_click=self._on_apply_button_clicked)
+
+    def _select_class(self, classification: str, selected: bool) -> None:
+        if selected:
+            self._selected_classes.add(classification)
+        else:
+            self._selected_classes.discard(classification)
+
+    def _on_apply_button_clicked(self) -> None:
+        self._viewmodel.apply_filter_tracks_by_class(
+            [
+                classification
+                for classification in self._classes
+                if classification in self._selected_classes
+            ]
+        )
+        logger().info("Filter tracks by classification applied")
+        self._dialog.close()
+
+
 class VisualizationFiltersForm(AbstractFrameFilter, ButtonForm):
 
     def __init__(
@@ -151,7 +215,6 @@ def __init__(
         self._viewmodel = view_model
         self._filter_by_date: ui.checkbox
         self._filter_by_class: ui.checkbox
-        self._filter_by_class_list: list = []
         self._button_previous_second: ui.button | None = None
         self._button_previous_frame: ui.button | None = None
         self._button_previous_event: ui.button | None = None
@@ -180,6 +243,7 @@ def __init__(
         self._filter_by_date_popup = FilterDateRangeForm(
             self._resource_manager, self._viewmodel
         )
+        self._filter_by_class_popup = FilterClassificationForm(self._viewmodel)
         self._input_seconds = FormFieldInteger(
             label_text=self._resource_manager.get(
                 VisualizationFiltersKeys.LABEL_SECONDS
@@ -320,33 +384,7 @@ def on_input_change(self, _: ValueChangeEventArguments) -> None:
         )
 
     def open_classification_dialog(self) -> None:
-        self._filter_by_class_list = self._viewmodel.get_classes()
-        with ui.dialog() as dialog, ui.card():
-            for classification_class in self._filter_by_class_list:
-                FormFieldCheckbox(
-                    label_text=classification_class,
-                    initial_value=classification_class in self._selected_classes(),
-                    on_value_change=lambda e: self.remove_or_add_class(
-                        classification_class
-                    ),
-                )
-            ui.button("Apply", on_click=lambda e: self.apply_new_classification(dialog))
-        dialog.open()
-
-    def _selected_classes(self) -> list[str]:
-        selected_classes = self._viewmodel.get_class_filter_selection()
-        return selected_classes if selected_classes else self._viewmodel.get_classes()
-
-    def apply_new_classification(self, dialog: ui.dialog) -> None:
-        self._viewmodel.apply_filter_tracks_by_class(self._filter_by_class_list)
-        self._filter_by_class_list = []
-        dialog.close()
-
-    def remove_or_add_class(self, class_name: str) -> None:
-        if class_name in self._filter_by_class_list:
-            self._filter_by_class_list.remove(class_name)
-        else:
-            self._filter_by_class_list.append(class_name)
+        self._filter_by_class_popup.open()
 
     def open_range_dialog(self) -> None:
         self._filter_by_date_popup.open()