Repository navigation
Edit sections and flows on double click in WebUI - #853
Merged
Merged
Conversation
CustomTable accepts an optional on_row_double_click_method that is called with the double-clicked row on Quasar's rowDblclick event. Synchronous and asynchronous handlers are supported. Row extraction is shared with the existing row click handling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Double-clicking a section in the section table selects it and opens the properties dialog, as in the customtkinter GUI. Double clicks are ignored while the form is disabled during a running action. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Double-clicking a flow in the flow table selects it and opens the properties dialog, as in the customtkinter GUI. Double clicks are ignored while the form is disabled during a running action. The selection handler is annotated with the list of rows it actually receives. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
briemla
enabled auto-merge
October 15, 2026 07:23
schubsen
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OP#10518
Problem
In the customtkinter GUI, double-clicking a section or flow opens its properties dialog (
frame_sections.py/frame_flows.py,_on_double_click->ViewModel.edit_selected_section_metadata()/edit_selected_flow()). The WebUI section and flow tables did not support this.Solution
CustomTable(nicegui/elements/table.py) accepts an optionalon_row_double_click_method, registered on Quasar'srowDblclickevent. The handler is called with the double-clicked row and may be sync or async. Row extraction is shared with the existing row click handling.SectionsFormandFlowFormuse it: a double click selects the row (viaset_selected_section_ids/set_selected_flow_ids, as for a single click) and then opens the properties dialog.disable()/enable()), double clicks are ignored.FlowForm._select_flowis now annotated with the list of rows it actually receives (needed for mypy).Tests
tests/unit/OTAnalytics/plugin_ui/nicegui_gui/nicegui/elements/test_table.py(async handler gets the row, sync handler works, no handler does not raise).tests/unit/OTAnalytics/plugin_ui/nicegui_gui/pages/sections_and_flow_form/test_sections_form.pyandtest_flow_form.py(double click -> selection set -> edit method awaited; ignored while disabled; works again after enable).tests/utils/nicegui_table.pysimulatesrowDblclickwith row arguments, becauseUser.triggersends no arguments.pytest tests/unit/OTAnalytics/plugin_ui: 223 passed, 5 skipped.pre-commit run --all-files: black, isort, flake8 and mypy pass.end-of-file-fixer(a test data.otflowfile),update-mypy-dependenciesandshellcheck(start_gui.sh, no.venvin the worktree) report issues in files this PR does not touch. Those changes were not included.🤖 Generated with Claude Code