fix: replace removed ast.Str with ast.Constant - #390
Merged
Conversation
Python 3.14 removed ast.Str, so every code path that analyses a skill's Python source raised AttributeError. Ten tests failed on 3.14, which left the suite unable to give evidence about anything else. ast.Constant also carries ints, bytes and None, so the string check is on the value rather than the node type -- a numeric decorator argument is no longer read as an intent filename.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 25, 2026
JarbasAl
marked this pull request as ready for review
August 25, 2026 20:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.14 removed
ast.Str. Every code path that analyses a skill's Python source hitAttributeError: module 'ast' has no attribute 'Str', so ten tests failed and the suite could not give evidence about anything else.ast.Constantalso carries ints, bytes andNone, so the check is on the value rather than the node type. A numeric decorator argument is no longer read as an intent filename.This blocks Renovate #198, which proposes moving the repo to Python 3.14.
Verification
Run locally in a clean venv on Python 3.14.6 (
uv venv+uv pip install -e . pytest):10 failed, 166 passed— all ten failures were this oneAttributeError.171 passed.Claims verified against source: the single
ast.Stroccurrence atovos_localize/analyzers/ast_analyzer.py:300(grep forast.Str|ast.Num|ast.Bytes|ast.NameConstantfinds no others). Test counts are from executed runs.