fix: submit translations against the branch the repo actually uses - #391
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
JarbasAl
force-pushed
the
fix/submission-target-branch
branch
2 times, most recently
from
August 25, 2026 20:50
820bdfc to
9ddc149
Compare
Skill repos do not agree on a branch name. OVOS repos use dev, many community repos use main or master. The SPA assumed dev everywhere, so a submission to a repo without a dev branch could not be checked out and the run died. The issue told the translator "a bot will create a PR automatically", no PR appeared, and nothing reported the failure -- the translation was lost in silence. The scanner already falls back dev -> main -> master when it clones, but discarded which branch won. It now records that branch, and the branch travels with the skill data into repos.json and the editor, so submissions and "edit on GitHub" links target a ref that exists. Both workflows verify the requested branch against the remote and fall back to the repository default, and both now comment on the issue when they fail, so a broken submission is visible instead of silent.
JarbasAl
marked this pull request as ready for review
August 25, 2026 21:30
JarbasAl
force-pushed
the
fix/submission-target-branch
branch
from
August 25, 2026 21:30
9ddc149 to
ac3b802
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translations submitted for a skill repo that has no
devbranch were silently lost.The SPA hardcoded
devas the submission target. Skill repos do not agree on a branch name: OVOS repos usedev, many community repos usemainormaster. When the branch did not exist,actions/checkoutcould not fetch the ref and the job died. The issue still told the translator "A bot will create a PR automatically", no PR appeared, and nothing reported the failure.This is not hypothetical. Three Kabyle translations submitted to
OscillateLabsLLC/skill-homeassistant(default branchmain) failed this way, while same-day submissions to OpenVoiceOS repos succeeded.What changed
RepoScanner.clone_or_pullalready fell backdev→main→master, but threw away which branch won. It now returns that branch, and the branch travels with the skill data intorepos.json, the per-skill JSON, and the editor. Submissions and "edit on GitHub" links target a ref that exists.Both workflows now verify the requested branch against the remote and fall back to the repository's default branch, so an old or hand-edited issue cannot reintroduce the failure. Both also comment on the originating issue when the job fails, so a broken submission is visible rather than silent. These are automation-authored comments designed into the workflow.
The "edit on GitHub" links were wrong for the same reason and are fixed by the same change.
Verification
Clean venv on Python 3.14.6:
ovos_localize/sync/github.pyandscripts/generate_data.pywhile keeping the tests:7 failed, then7 passedonce restored.16 passedbefore,23 passedafter — no regression.The full suite also reports ten failures from
ast.Stron Python 3.14, unrelated to this change and present ondev. Fixed separately in #390.Not yet verified: the live end-to-end submission, which needs this deployed to Pages. Re-driving issues #387, #388 and #389 is the acceptance test.