Skip to content

condition / report timeframe logic #17

Description

@emphasize

this came up while thinking about #14

if i'm asking about a condition (clear, rain, snow, thunderstorm, ...) on a specific day, the report timeframe is set to DAILY. *)

This would mean, the condition has to be dominant across the day - or in case of "today" happening right now. Otherwise it isn't reported. While this is inevitable for future events > 48 hours (hourly data constraint), it is nonsense below.

If you're asking for a thunderstorm you care about the happening, not if it is the dominant condition of the day. If the day in question is within 48 hours, hourly data should be used.

That said, in my fork i handle upcoming conditions a bit more extensive.

  • the time it happens
  • the duration
  • in case of precipitation the volume (rain_vol, snow_vol)

This might be a usefull addition for OVOS

*) Worse than that, if asked for "today" the timeframe isn't set, with the default being CURRENT - i.e. the current condition.
("today" isn't even a part of relative-day.voc)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions