fix: detach_skill removes intents by skill_id prefix, not substring

handle_detach_skill selected intents to remove with `skill_id in i`, a
substring test over the full "<skill_id>:<name>" intent name. A skill
whose id is a substring of another skill's id (e.g. "me" against
"skill-a.me") wiped the other skill's intents when it detached, and an
unregistered id like "skill" cleared every intent containing that text.
The entity branch of the same handler already matched on the
"<skill_id>:" prefix, as do adapt and padatious.

Intents are now selected with startswith(skill_id + ":"), the colon being
the intent-name namespace separator (OVOS-MSG-1 §2.1.1), so the owner of
"a.b:c" is exactly "a.b".

Regression test test/test_detach_skill_prefix.py: 2 failed before the fix
(registered_intents emptied to [] in both cases), 2 pass after. Full
suite: 90 passed, 2 skipped.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Author: JarbasAl

padacioso/opm.py

@@ -304,12 +304,12 @@ def handle_detach_skill(self, message):
             message (Message): message triggering action
         """
         skill_id = message.data['skill_id']
-        remove_list = [i for i in self.registered_intents if skill_id in i]
+        prefix = skill_id + ":"
+        remove_list = [i for i in self.registered_intents if i.startswith(prefix)]
         for i in remove_list:
             self.__detach_intent(i)
-        skill_id_colon = skill_id + ":"
         for en in self.registered_entities:
-            if en["name"].startswith(skill_id_colon):
+            if en["name"].startswith(prefix):
                 self.__detach_entity(en["name"], en["lang"])
 
     def _valid_samples(self, samples, topic, name, lang):

test/test_detach_skill_prefix.py

@@ -0,0 +1,43 @@
+"""``detach_skill`` removes only the intents the named skill owns. The owning
+skill of ``a.b:c`` is exactly ``a.b`` (colon namespace separator, OVOS-MSG-1
+§2.1.1), so a skill whose id is a substring of another skill's id must not
+take the other skill's intents down with it."""
+import unittest
+
+from ovos_bus_client.message import Message
+from ovos_utils.fakebus import FakeBus
+
+from padacioso.opm import PadaciosoPipeline
+
+
+class TestDetachSkillPrefixMatch(unittest.TestCase):
+    def setUp(self):
+        self.p = PadaciosoPipeline(FakeBus(), {"any": 1})
+        self.lang = self.p.lang
+
+    def _register(self, name):
+        self.p.register_intent(Message(
+            "padatious:register_intent",
+            {"name": name, "samples": ["hello " + name.split(":")[1]],
+             "lang": self.lang}))
+
+    def test_substring_skill_id_keeps_other_skills(self):
+        for name in ("skill-a.me:one", "skill-b.me:bone", "me:mine"):
+            self._register(name)
+        self.p.handle_detach_skill(Message("detach_skill", {"skill_id": "me"}))
+        self.assertEqual(sorted(self.p.registered_intents),
+                         ["skill-a.me:one", "skill-b.me:bone"])
+        names = set(self.p.containers[self.lang].intent_samples)
+        self.assertIn("skill-a.me:one", names)
+        self.assertIn("skill-b.me:bone", names)
+        self.assertNotIn("me:mine", names)
+
+    def test_unregistered_substring_skill_id_removes_nothing(self):
+        for name in ("victim.skill:on", "otherskill:on"):
+            self._register(name)
+        self.p.handle_detach_skill(Message("detach_skill", {"skill_id": "skill"}))
+        self.assertEqual(sorted(self.p.registered_intents),
+                         ["otherskill:on", "victim.skill:on"])
+        names = set(self.p.containers[self.lang].intent_samples)
+        self.assertEqual(names & {"victim.skill:on", "otherskill:on"},
+                         {"victim.skill:on", "otherskill:on"})