Skip to content

Commit 1d03d97

Browse files
committed
fix(docker): clarify GPU smoke completion and exit status
1 parent b6ae01d commit 1d03d97

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

‎docker/README.md‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,9 @@ docker compose run --rm -T gpu-check
7575

7676
This checks BF16, compiled forward/backward, DeepSpeed FusedAdam and multi-GPU
7777
NCCL all-reduce with networking disabled. It requires the cache/output mounts,
78-
but no weights or dataset. Follow it with real inference or training.
78+
but no weights or dataset. Success requires the entire command to exit with
79+
code 0: worker computation messages alone do not rule out a shutdown failure.
80+
Follow it with real inference or training.
7981

8082
## Serve
8183

‎docker/gpu_smoke.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def operation(value):
6464
finally:
6565
dist.destroy_process_group()
6666
torch.cuda.synchronize()
67-
print("GPU smoke passed.", flush=True)
67+
print(f"Rank {rank}: GPU computation checks completed.", flush=True)
6868

6969

7070
if __name__ == "__main__":

0 commit comments

Comments
 (0)