You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Found by the #1651 retroactive sweep (the producer-closed-COMPLETE-without-consumer class). This is the class in its purest form: a producer whose only consumer is its own test.
The finding, verified at the artifact
tools/analytics/tier_rollup.py (shipped by #1242, closed complete in v0.8.0) exposes two halves:
The events half is alive:read_events is imported by tools/analytics/multiplant_history.py:63 — consumed in production. ✓
The aged-rollup half is fully dark, both directions:
Never built — repo-wide grep: no justfile recipe, no CI workflow, no hook invokes build_rollups or the module's main(). The rollup parquet is not being produced on any cadence.
Never read — read_envelope, pick_tier, and trajectory_series have zero production importers. The only file exercising them is test_tier_rollup.py.
The intended consumer denies it landed — tools/analytics/dashboard.py:115 still reads "…the rollup tier lands" (future tense). The consumer's own comment says the producer it was waiting for never arrived — while the producer's issue closed complete.
Why it stayed invisible
Every layer answers its own question correctly: the module's tests pass, read_events works, #1242's ACs were about the code existing and behaving. Nobody's question was "does anything build or read the aged tiers?" — the #1651 defect class exactly ("closing COMPLETED without saying so").
What this issue is
A decision, then possibly work — not automatically a build ticket:
Wire it — long-span dashboard/history reads go through read_envelope/pick_tier (the original ADR-0031 intent), and a recipe/hook builds rollups on the compaction cadence; or
Retire it — if the recent full-fidelity tier + events cover real usage, delete the dead half rather than carry it (ADR-0031 amendment).
Related: #1696 (the tier-visibility surface) is where this darkness would have been visible to the operator — this finding is that page's justification restated as a defect. #1466 is the sibling (dark store on the root deployment).
Milestone deliberately unset — placement is the maintainer's call (scope addition vs 0.9.x).
Found by the #1651 retroactive sweep (the producer-closed-COMPLETE-without-consumer class). This is the class in its purest form: a producer whose only consumer is its own test.
The finding, verified at the artifact
tools/analytics/tier_rollup.py(shipped by #1242, closed complete in v0.8.0) exposes two halves:The events half is alive:
read_eventsis imported bytools/analytics/multiplant_history.py:63— consumed in production. ✓The aged-rollup half is fully dark, both directions:
build_rollupsor the module'smain(). The rollup parquet is not being produced on any cadence.read_envelope,pick_tier, andtrajectory_serieshave zero production importers. The only file exercising them istest_tier_rollup.py.tools/analytics/dashboard.py:115still reads "…the rollup tier lands" (future tense). The consumer's own comment says the producer it was waiting for never arrived — while the producer's issue closed complete.Why it stayed invisible
Every layer answers its own question correctly: the module's tests pass,
read_eventsworks, #1242's ACs were about the code existing and behaving. Nobody's question was "does anything build or read the aged tiers?" — the #1651 defect class exactly ("closing COMPLETED without saying so").What this issue is
A decision, then possibly work — not automatically a build ticket:
read_envelope/pick_tier(the original ADR-0031 intent), and a recipe/hook builds rollups on the compaction cadence; orRelated: #1696 (the tier-visibility surface) is where this darkness would have been visible to the operator — this finding is that page's justification restated as a defect. #1466 is the sibling (dark store on the root deployment).
Milestone deliberately unset — placement is the maintainer's call (scope addition vs 0.9.x).
— Workflow ⚙️ (filing, from the #1651 sweep)