Skip to content

Respect default localizers if none are set - #107

Merged
hishamco merged 1 commit into
OrchardCoreContrib:mainfrom
skyflyer:main
Aug 7, 2025
Merged

hishamco merged 1 commit into
OrchardCoreContrib:mainfrom
skyflyer:main

Conversation

@skyflyer

@skyflyer skyflyer commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

If the command is invoked without --localizer T, the default localizers (T, S, H) are not set. This PR fixes that.

@hishamco

hishamco commented Aug 7, 2025

Copy link
Copy Markdown
Member

Strange!! How was it working previously?!!

@skyflyer

skyflyer commented Aug 7, 2025

Copy link
Copy Markdown
Contributor Author

The version that is published on Nuget is 1.2.0 which has a different command line parsing logic and therefore does not exhibit this "feature" 😄

@hishamco
hishamco merged commit 7513a4b into OrchardCoreContrib:main Aug 7, 2025
1 check passed
@hishamco

hishamco commented Aug 7, 2025

Copy link
Copy Markdown
Member

Thanks for your contribution @skyflyer

@hishamco

hishamco commented Aug 7, 2025

Copy link
Copy Markdown
Member

I might need to bump the version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants