Repository navigation
RDEV-9911 - Shadow dom mouse leave - #53
Merged
OS-josesoares merged 1 commit intoOct 23, 2026
Merged
Conversation
tbragaf
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Monaco detects that the mouse has left the editor with a listener on document that treats !viewDomNode.contains(e.target) as a leave (vscode microsoft#138789). When the editor is inside a shadow root, as in ODC Studio and Service Studio where every Monaco editor is hosted in a ReactView ViewFrame with an open shadow root, e.target seen from document is the shadow host, so every mouse move inside the editor fires a fake mouse leave. The hover controller hides the hover on that leave, so hovers never open when the mouse rests and the CSS editor's color picker closes as soon as the mouse moves toward it (RDEV-9911). Checking the original target, e.composedPath()[0], as proposed upstream in vscode PR microsoft#166240, fixes this for open shadow roots and still detects real exits from the editor; the PR also bumps monaco-editor-core to 0.55.1-os2 and adds a regression test, which no pipeline runs, so run it by hand after upstream syncs.