Skip to content

fix(build): link the split ggml archives with static whisper #2296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
naanlizard wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −1
Open

fix(build): link the split ggml archives with static whisper #2296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion cmake/Dependencies.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,8 +378,17 @@ endif()

# Whisper GGML
if(PKG_WHISPER_FOUND)
# Static whisper splits ggml into ggml + ggml-base + ggml-cpu; all three
# must follow libwhisper.a on the link line (test binaries surface the
# miss; the main binary only survived by link order).
find_library(GGML_LIB ggml HINTS ${OME_DEP_PREFIX}/lib ${OME_DEP_PREFIX}/lib64)
find_library(GGML_BASE_LIB ggml-base HINTS ${OME_DEP_PREFIX}/lib ${OME_DEP_PREFIX}/lib64)
find_library(GGML_CPU_LIB ggml-cpu HINTS ${OME_DEP_PREFIX}/lib ${OME_DEP_PREFIX}/lib64)
set_property(TARGET PkgConfig::PKG_WHISPER APPEND PROPERTY INTERFACE_LINK_LIBRARIES "${GGML_CPU_LIB}")
foreach(_ggml_lib IN ITEMS "${GGML_LIB}" "${GGML_CPU_LIB}" "${GGML_BASE_LIB}")
if(_ggml_lib)
set_property(TARGET PkgConfig::PKG_WHISPER APPEND PROPERTY INTERFACE_LINK_LIBRARIES "${_ggml_lib}")
endif()
endforeach()
set_property(TARGET PkgConfig::PKG_WHISPER APPEND PROPERTY INTERFACE_LINK_LIBRARIES gomp)

if(OME_HWACCEL_NVIDIA)
Expand Down Expand Up @@ -410,6 +419,8 @@ if(PKG_WHISPER_FOUND)
endif()
endif()

unset(GGML_LIB CACHE)
unset(GGML_BASE_LIB CACHE)
unset(GGML_CPU_LIB CACHE)
unset(NV_CUBLAS_LIB CACHE)
unset(NV_CUBLASLT_LIB CACHE)
Expand Down
Loading