Skip to content

[ci skip] Correct MOB_GRIEFING javadoc on explode events #14195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CJH3139 wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −6
Open

[ci skip] Correct MOB_GRIEFING javadoc on explode events #14195

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a33042b
Correct MOB_GRIEFING javadoc on explode events
CJH3139 Aug 18, 2026
7f4aa4f
Update paper-api/src/main/java/org/bukkit/event/entity/EntityExplodeE…
CJH3139 Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions paper-api/src/main/java/org/bukkit/event/block/BlockExplodeEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@
* Note that due to the nature of explosions, {@link #getBlock()} will always be
* an air block. {@link #getExplodedBlockState()} should be used to get
* information about the block state that exploded.
* <p>
* The event isn't called if the {@link org.bukkit.GameRules#MOB_GRIEFING}
* is disabled as no block interaction will occur.
*/
public class BlockExplodeEvent extends BlockEvent implements Cancellable {

Expand Down
10 changes: 7 additions & 3 deletions paper-api/src/main/java/org/bukkit/event/entity/EntityExplodeEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,13 @@
import org.jetbrains.annotations.NotNull;

/**
* Called when an entity explodes interacting with blocks. The
* event isn't called if the {@link org.bukkit.GameRules#MOB_GRIEFING}
* is disabled as no block interaction will occur.
* Called when an entity explodes interacting with blocks.
* <p>
* Explosions caused by mobs do no tinteract with blocks
Comment thread
CJH3139 marked this conversation as resolved.
Outdated
* while {@link org.bukkit.GameRules#MOB_GRIEFING} is disabled
* as no block interaction will occur. That game rule does not
Comment on lines +16 to +18

@Warriorrrr Warriorrrr Aug 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should still say that explosions caused by mobs don't call the event, what's currently written reads bit weirdly since it says no block interactions will occur twice without saying anything about whether it's still called or not.

* affect other explosions. For example, a wind charge still calls this event
* with an {@link ExplosionResult#TRIGGER_BLOCK} result.
*/
public class EntityExplodeEvent extends EntityEvent implements Cancellable {

Expand Down
Loading