Upgrading to NUnit4 including all required dependencies (#340)

* Upgrading to NUnit4 including all required dependencies

* Bump approvals

* adjust target frameworks

* Update ci.yml

* Netstandard

* Bump and fix approvals

---------

Co-authored-by: Daniel Marbach <daniel.marbach@particular.net>
Co-authored-by: danielmarbach <danielmarbach@users.noreply.github.com>

Author: lailabougria

.github/workflows/ci.yml

@@ -32,10 +32,7 @@ jobs:
         uses: actions/setup-dotnet@v4.0.1
         with:
           dotnet-version: |
-            3.1.x
-            5.0.x   
-            6.0.x
-            7.0.x        
+            8.0.x        
       - name: Build
         run: dotnet build src --configuration Release
       - name: Upload packages

src/ServiceControl.Contracts.Tests/API/APIApprovals.cs

@@ -1,9 +1,8 @@
-namespace NServiceBus.PlatformConnection.UnitTests.API
+namespace ServiceControl.Contracts.Tests.API
 {
     using NUnit.Framework;
     using Particular.Approvals;
     using PublicApiGenerator;
-    using ServiceControl.Contracts;
 
     [TestFixture]
     class APIApprovals

src/ServiceControl.Contracts.Tests/ServiceControl.Contracts.Tests.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net472;netcoreapp3.1;net6.0;net7.0</TargetFrameworks>
+    <TargetFramework>net8.0</TargetFramework>
   </PropertyGroup>
 
   <ItemGroup>
@@ -11,10 +11,10 @@
   <ItemGroup>
     <PackageReference Include="GitHubActionsTestLogger" Version="2.4.1" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.0" />
-    <PackageReference Include="NUnit" Version="3.14.0" />
+    <PackageReference Include="NUnit" Version="4.2.1" />
     <PackageReference Include="NUnit3TestAdapter" Version="4.6.0" />
     <PackageReference Include="PublicApiGenerator" Version="11.1.0" />
-    <PackageReference Include="Particular.Approvals" Version="0.6.0" />
+    <PackageReference Include="Particular.Approvals" Version="2.0.0" />
   </ItemGroup>
 
 </Project>

src/ServiceControl.Contracts/ServiceControl.Contracts.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net461;netcoreapp3.1</TargetFrameworks>
+    <TargetFramework>netstandard2.0</TargetFramework>
     <Description>Message contracts for external events pushed by ServiceControl</Description>
     <SignAssembly>true</SignAssembly>
     <AssemblyOriginatorKeyFile>..\ServiceControl.Contracts.snk</AssemblyOriginatorKeyFile>