Skip to content

Commit 8bbc1b4

Browse files
committed
address review feedback
1 parent 1c7a201 commit 8bbc1b4

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/sdl/surface.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ void free_surface(surface& surf)
3838
void make_neutral(surface& surf)
3939
{
4040
if(surf && surf->format != SDL_PIXELFORMAT_ARGB8888) {
41-
surf = surf.clone();
41+
surf = surface(SDL_ConvertSurface(surf, SDL_PIXELFORMAT_ARGB8888));
4242
}
4343
}
4444

@@ -100,7 +100,7 @@ surface surface::clone() const
100100
return {};
101101
}
102102
// Use SDL_ConvertSurfaceFormat to make a copy
103-
return surface(SDL_ConvertSurface(surface_, SDL_PIXELFORMAT_ARGB8888));
103+
return surface(SDL_DuplicateSurface(surface_));
104104
}
105105

106106
point surface::size() const

0 commit comments

Comments
 (0)