Skip to content

Commit 177cab2

Browse files
committed
(featurizers) Point VoronoiNN import to pymatgen.core.local_env in new pymatgen versions while keeping the old one (to be deprecated in 2027) as a fallback on ImportError
1 parent 0c916da commit 177cab2

4 files changed

Lines changed: 16 additions & 4 deletions

File tree

‎pysipfenn/descriptorDefinitions/KS2022.py‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,10 @@
2929
from tqdm import tqdm
3030
import numpy as np
3131
from pymatgen.core import Structure, Element, PeriodicSite
32-
from pymatgen.analysis.local_env import VoronoiNN
32+
try:
33+
from pymatgen.core.local_env import VoronoiNN
34+
except ImportError:
35+
from pymatgen.analysis.local_env import VoronoiNN
3336
from pymatgen.symmetry.analyzer import SpacegroupAnalyzer
3437

3538
# Certain hard-coded basic elemental properties used in the featurization (compatible with Magpie references).

‎pysipfenn/descriptorDefinitions/KS2022_dilute.py‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,10 @@
2828
from tqdm import tqdm
2929
import numpy as np
3030
from pymatgen.core import Structure, Element, PeriodicSite
31-
from pymatgen.analysis.local_env import VoronoiNN
31+
try:
32+
from pymatgen.core.local_env import VoronoiNN
33+
except ImportError:
34+
from pymatgen.analysis.local_env import VoronoiNN
3235
from pymatgen.symmetry.analyzer import SpacegroupAnalyzer
3336

3437
# Certain hard-coded basic elemental properties used in the featurization (compatible with Magpie references).

‎pysipfenn/descriptorDefinitions/KS2022_randomSolutions.py‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,10 @@
3131
from tqdm.contrib.concurrent import process_map
3232
import numpy as np
3333
from pymatgen.core import Structure, Element, Composition, PeriodicSite
34-
from pymatgen.analysis.local_env import VoronoiNN
34+
try:
35+
from pymatgen.core.local_env import VoronoiNN
36+
except ImportError:
37+
from pymatgen.analysis.local_env import VoronoiNN
3538

3639
# Certain hard-coded basic elemental properties used in the featurization (attribute_matrix is compatible with Magpie references,
3740
# and maxFeaturesInOQMD is based on the 2017 snapshot of OQMD, which was current when we started and will be retained in KS2022, but

‎pysipfenn/descriptorDefinitions/Ward2017.py‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,10 @@
2727
from tqdm import tqdm
2828
import numpy as np
2929
from pymatgen.core import Structure, Element, PeriodicSite
30-
from pymatgen.analysis.local_env import VoronoiNN
30+
try:
31+
from pymatgen.core.local_env import VoronoiNN
32+
except ImportError:
33+
from pymatgen.analysis.local_env import VoronoiNN
3134

3235
# Certain hard-coded basic elemental properties used in the featurization (compatible with Magpie references).
3336
periodic_table_size = 112

0 commit comments

Comments
 (0)