Repository navigation
Commit 0406650
committed
feat(effects): EFF001 effect-storm — a real core stability analysis (P-020)
Answer P-020's gating question (Open question 1) for real: the unstable-
dependency "effect storm" is a genuinely NEW core analysis, not an OWN001
leak and not a frontend heuristic. The honest fact/verdict split holds end
to end — the OwnTS frontend emits only facts; the core decides.
Core (ownlang/effects.py): a dependency-identity stability lattice
(STABLE < UNKNOWN < UNSTABLE) computed to a fixpoint over the render-scope
binding references. An object/array literal in render scope is UNSTABLE
(fresh identity each render); useMemo/useCallback/useRef/prop/primitive are
STABLE; an alias/derivation takes the worst of its refs (instability
propagates); an opaque call is UNKNOWN (conservative — no finding). An
effect is EFF001 iff it does IO AND a dep is provably UNSTABLE. Its own
core code (like DI001), never masquerading as OWN001.
Bridge (ownlang/ownir.py): a new optional, additive `effects` block in
OwnIR (does not bump the version, mirrors `services`); _effect_findings
routes it through effects.py to an EFF001 Finding at the effect call site,
with a reachability slice (effect -> the fix site) and a SARIF rule.
load() shape-checks the block; malformed input degrades to no findings.
Frontend (frontend/ownts/): emits the `effects` facts — per useEffect, the
dep list, an IO flag, and the component's render-scope binding table with
each binding's syntactic init kind + references. The old stderr-only EFF001
heuristic is removed in favour of the core verdict.
- ownlang/effects.py: the analysis (lattice, propagation, cycle-safe)
- ownlang/diagnostics.py: register EFF001 title
- examples/EffectStorm.tsx: showcase — 2 storms fire (object dep + derived
alias), memo/ref/call/primitive/no-IO stay silent (low false positives)
- tests/test_effects.py (29 checks) wired into run_tests.py; ownts spike
test now pins 3xOWN001+EFF001 / 0 / 2xEFF001
- CI ownts-react-effects job extended; P-020 + README updated
mypy --strict clean; ruff clean; full suite green.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PVeuchch67CtjSbizYm8gi1 parent 634594f commit 0406650
11 files changed
Lines changed: 665 additions & 82 deletions
File tree
- .github/workflows
- docs/proposals
- frontend/ownts
- examples
- ownlang
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
999 | 999 | | |
1000 | 1000 | | |
1001 | 1001 | | |
1002 | | - | |
1003 | | - | |
1004 | | - | |
| 1002 | + | |
| 1003 | + | |
| 1004 | + | |
| 1005 | + | |
| 1006 | + | |
| 1007 | + | |
1005 | 1008 | | |
1006 | 1009 | | |
1007 | 1010 | | |
| |||
1010 | 1013 | | |
1011 | 1014 | | |
1012 | 1015 | | |
1013 | | - | |
| 1016 | + | |
1014 | 1017 | | |
1015 | 1018 | | |
1016 | 1019 | | |
| |||
1023 | 1026 | | |
1024 | 1027 | | |
1025 | 1028 | | |
1026 | | - | |
1027 | | - | |
1028 | | - | |
| 1029 | + | |
| 1030 | + | |
| 1031 | + | |
| 1032 | + | |
| 1033 | + | |
| 1034 | + | |
| 1035 | + | |
| 1036 | + | |
| 1037 | + | |
| 1038 | + | |
| 1039 | + | |
| 1040 | + | |
| 1041 | + | |
| 1042 | + | |
| 1043 | + | |
| 1044 | + | |
| 1045 | + | |
| 1046 | + | |
1029 | 1047 | | |
1030 | 1048 | | |
1031 | 1049 | | |
1032 | 1050 | | |
1033 | 1051 | | |
1034 | 1052 | | |
1035 | | - | |
| 1053 | + | |
1036 | 1054 | | |
1037 | 1055 | | |
1038 | 1056 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
12 | 17 | | |
13 | 18 | | |
14 | 19 | | |
| |||
151 | 156 | | |
152 | 157 | | |
153 | 158 | | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
160 | 169 | | |
161 | 170 | | |
162 | 171 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
25 | 28 | | |
26 | 29 | | |
27 | 30 | | |
| |||
30 | 33 | | |
31 | 34 | | |
32 | 35 | | |
33 | | - | |
34 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
35 | 39 | | |
36 | 40 | | |
37 | 41 | | |
38 | 42 | | |
39 | 43 | | |
| 44 | + | |
40 | 45 | | |
41 | 46 | | |
42 | 47 | | |
43 | 48 | | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
49 | 55 | | |
50 | 56 | | |
51 | 57 | | |
52 | 58 | | |
53 | | - | |
| 59 | + | |
54 | 60 | | |
55 | | - | |
| 61 | + | |
56 | 62 | | |
57 | | - | |
58 | | - | |
59 | | - | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
60 | 66 | | |
61 | | - | |
62 | | - | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
63 | 73 | | |
64 | 74 | | |
65 | | - | |
66 | | - | |
67 | | - | |
| 75 | + | |
68 | 76 | | |
69 | 77 | | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
70 | 87 | | |
71 | 88 | | |
72 | 89 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
0 commit comments