Repository navigation
Commit 099e73c
committed
fix(d5): don't crash on unknown callees; FQ factory keys; preserve call args (CI fix + Codex/CodeRabbit)
The extractor's new call ops surfaced calls to callees not in functions[] (BCL /
extension methods like GetRequiredService), which crashed check_facts with
OWN040. Plus three review items:
- (CI crash) Gate the Call emission on a RESOLVABLE callee (in the MOS or a sink
extern); an unknown callee is dropped (no claim), never lowered to a Call that
raises OWN040. Add OWN040 to the bridge-artifact skip list belt-and-suspenders.
Regression test: a call to an unknown callee makes no claim and does not crash.
- (Codex P2) Fully-qualify the factory summary key on BOTH sides
({Namespace.Type}.{Method} via FlowFunctionName + ContainingType.ToDisplayString)
so two same-named factories across namespaces never alias into a false OWN001.
- (CodeRabbit Major) Preserve the call's tracked identifier args instead of
Array.Empty, so the core can apply the callee's per-argument effects.
- (CodeRabbit Minor) Anchor the CI assertion to FactoryLeakSample.cs:<line> at the
call site, not just any match of 'factoryLeak'.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fmwk5ruExKy5fQ77CJ2NtF1 parent 5291fa9 commit 099e73c
4 files changed
Lines changed: 66 additions & 8 deletions
File tree
- .github/workflows
- frontend/roslyn/OwnSharp.Extractor
- ownlang
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
827 | 827 | | |
828 | 828 | | |
829 | 829 | | |
830 | | - | |
831 | | - | |
| 830 | + | |
| 831 | + | |
832 | 832 | | |
833 | 833 | | |
834 | 834 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
578 | 578 | | |
579 | 579 | | |
580 | 580 | | |
581 | | - | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
582 | 586 | | |
583 | 587 | | |
584 | 588 | | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
585 | 599 | | |
586 | 600 | | |
587 | 601 | | |
| |||
785 | 799 | | |
786 | 800 | | |
787 | 801 | | |
788 | | - | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
789 | 816 | | |
| 817 | + | |
790 | 818 | | |
791 | 819 | | |
792 | 820 | | |
| |||
3355 | 3383 | | |
3356 | 3384 | | |
3357 | 3385 | | |
3358 | | - | |
| 3386 | + | |
3359 | 3387 | | |
3360 | 3388 | | |
3361 | 3389 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1075 | 1075 | | |
1076 | 1076 | | |
1077 | 1077 | | |
| 1078 | + | |
| 1079 | + | |
| 1080 | + | |
| 1081 | + | |
| 1082 | + | |
1078 | 1083 | | |
1079 | 1084 | | |
1080 | 1085 | | |
| |||
1530 | 1535 | | |
1531 | 1536 | | |
1532 | 1537 | | |
1533 | | - | |
| 1538 | + | |
| 1539 | + | |
| 1540 | + | |
| 1541 | + | |
| 1542 | + | |
| 1543 | + | |
| 1544 | + | |
| 1545 | + | |
1534 | 1546 | | |
1535 | 1547 | | |
1536 | 1548 | | |
| |||
1540 | 1552 | | |
1541 | 1553 | | |
1542 | 1554 | | |
1543 | | - | |
1544 | 1555 | | |
1545 | 1556 | | |
1546 | 1557 | | |
| |||
1600 | 1611 | | |
1601 | 1612 | | |
1602 | 1613 | | |
1603 | | - | |
| 1614 | + | |
| 1615 | + | |
| 1616 | + | |
| 1617 | + | |
| 1618 | + | |
1604 | 1619 | | |
1605 | 1620 | | |
1606 | 1621 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1471 | 1471 | | |
1472 | 1472 | | |
1473 | 1473 | | |
| 1474 | + | |
| 1475 | + | |
| 1476 | + | |
| 1477 | + | |
| 1478 | + | |
| 1479 | + | |
| 1480 | + | |
| 1481 | + | |
| 1482 | + | |
| 1483 | + | |
| 1484 | + | |
| 1485 | + | |
| 1486 | + | |
| 1487 | + | |
| 1488 | + | |
1474 | 1489 | | |
1475 | 1490 | | |
1476 | 1491 | | |
| |||
0 commit comments