Repository navigation
Commit 0e7125b
committed
docs(d5): correct the unresolved-log contract; test return extern boundary
CodeRabbit review: the solve_with_log / module docstrings claimed the extern
boundary is the ONLY source of `unknown`. It isn't — resolve_return also yields
`unknown` (without logging) for a return-forward cycle, an un-remappable aliasOf,
and an unrecognised return kind, and lookup does for a missing param index. Those
are intrinsic, precision-safe, deterministic-from-input degradations, not
"gave up on something external", so they are intentionally not logged. Soften the
wording: the log covers extern (outside-the-analyzed-set) boundaries, not every
`unknown`.
Also add a forward-return extern-boundary log assertion — the return chase is a
separate code path from the param-forward case the existing test covered, so a
regression in return-boundary logging would otherwise slip through.
Docs/test only — no behaviour change. ownership 44/44, ownir 194/194, mypy
--strict, ruff all green.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019846YSZ35c7CdkWQ1qX5gm1 parent e2bb4ca commit 0e7125b
2 files changed
Lines changed: 18 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
35 | 37 | | |
36 | 38 | | |
37 | 39 | | |
| |||
243 | 245 | | |
244 | 246 | | |
245 | 247 | | |
246 | | - | |
247 | | - | |
248 | | - | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
249 | 254 | | |
250 | 255 | | |
251 | 256 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
142 | 148 | | |
143 | 149 | | |
144 | 150 | | |
| |||
0 commit comments