Repository navigation
Commit 23c89f2
committed
fix(ownts): don't mistake an options object for the cleanup block (CodeRabbit)
Follow-up to the merged #145. For an EXPRESSION-bodied effect cleanup whose
removeEventListener passes an options object —
return () => el.removeEventListener("x", h, {capture: true})
_cleanup_span did `find("{")`, which landed on the `{` of `{capture: true}`,
so _match_block ended the span at the options `}` and truncated the trailing `)`.
The resulting cleanup no longer parsed via _LISTENER, so _listener_call returned
None and a correctly-released listener was reported as a false OWN001 leak.
Now a cleanup is treated as block-bodied only when the first non-whitespace
character after `=>` is `{`; otherwise it is an expression body ending at the
line break (which keeps the whole call, options object and closing `)` included).
New fixture EffectExprCleanup.tsx (expect zero findings), pinned in test_ownts.py
and a CI step. Full suite green (effects 31/31, ownir 194/194); ruff + mypy
--strict clean; all existing fixtures unchanged.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PVeuchch67CtjSbizYm8gi1 parent 3703b05 commit 23c89f2
4 files changed
Lines changed: 42 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1088 | 1088 | | |
1089 | 1089 | | |
1090 | 1090 | | |
| 1091 | + | |
| 1092 | + | |
| 1093 | + | |
| 1094 | + | |
| 1095 | + | |
| 1096 | + | |
| 1097 | + | |
| 1098 | + | |
| 1099 | + | |
| 1100 | + | |
1091 | 1101 | | |
1092 | 1102 | | |
1093 | 1103 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
390 | 390 | | |
391 | 391 | | |
392 | 392 | | |
393 | | - | |
394 | | - | |
395 | | - | |
396 | | - | |
397 | | - | |
398 | | - | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
399 | 404 | | |
400 | 405 | | |
401 | 406 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
60 | 66 | | |
61 | 67 | | |
62 | 68 | | |
| |||
0 commit comments