Skip to content

Commit 2e1b31b

Browse files
committed
docs(P-017/P-020): correct the OWNTS↔EFF rule mapping (Codex review #140)
Two cross-reference fixes flagged by Codex: - The cleanup-rule cross-walk was off: OWNTS004 is AbortController, which maps to EFF005 — not EFF004 (timers = OWNTS002). State the accurate one-to-one: OWNTS002/003/004 ↔ EFF004/EFF003/EFF005. Fixed in P-017's reference note and in P-020's open-question #3. - Stop marketing the OWNTS001 cleanup rule (→ OWN001) with the request-storm / Cloudflare story. That shape is EFF001/002 (new dependency-stability analysis the core lacks), per P-020's honest split — the conflation P-020 explicitly avoids. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QnGqHwVb2H1jZ71f498MFa
1 parent 71237c2 commit 2e1b31b

2 files changed

Lines changed: 14 additions & 9 deletions

File tree

‎docs/proposals/P-017-multi-stack-frontends.md‎

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,10 @@ surface in this ecosystem (`npm install`, drop into an existing config):
132132
The `useEffect`/React rows above are the authoring surface; the deeper **`Own.React`
133133
effect profile** (the `EFF001–005` catalog, the effect-storm analysis, and the
134134
honest Cloudflare framing) is specified in
135-
[P-020](P-020-ownts-react-effects.md). `OWNTS003/004` and `EFF003/004` are the same
136-
cleanup semantics — P-020 is the canonical home; the ESLint rules reference it.
135+
[P-020](P-020-ownts-react-effects.md). The cleanup rules overlap one-to-one with the
136+
`Own.React` catalog — `OWNTS002`/`003`/`004` (timer / `subscribe` / `AbortController`)
137+
are the same semantics as `EFF004`/`EFF003`/`EFF005` respectively — so P-020 is the
138+
canonical home and the ESLint rules reference it rather than redefine it.
137139

138140
```
139141
eslint-plugin-own ← authoring rules for JS/TS (the user-facing surface)
@@ -142,9 +144,12 @@ ownlang/ (core) ← OwnIR → diagnostics (unchanged)
142144
```
143145

144146
The `OWNTS001` React `useEffect`-cleanup case is the recommended **marketing
145-
spike**: a 10-line bug everyone recognises, a "request storm / Cloudflare-style"
146-
story that sells itself, and the easiest plugin to distribute. It is a spike, not
147-
a frontend — one rule, one tier, end-to-end, before any breadth.
147+
spike**: a 10-line bug everyone recognises, and the easiest plugin to distribute. It
148+
is a spike, not a frontend — one rule, one tier, end-to-end, before any breadth.
149+
(The *request-storm / Cloudflare* angle is a **different** shape — `EFF001/002` in
150+
[P-020](P-020-ownts-react-effects.md), which needs new dependency-stability analysis
151+
the core does not have yet — not this cleanup rule. Don't market `OWNTS001` as
152+
catching request storms; that conflation is exactly what P-020 is careful to avoid.)
148153

149154
---
150155

‎docs/proposals/P-020-ownts-react-effects.md‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ has on the .NET side (P-013/P-015); 1/2/6/7 are this proposal's actual work.
154154
2. **Confidence tier.** `EFF001` clearly wants TS-mode type info (is the dep an
155155
object literal? does the body do IO?). What, if anything, survives into JS mode
156156
(P-017's heuristic tier) as a warning?
157-
3. **Overlap with P-017's `OWNTS003/004`.** `EFF003/004` restate the cleanup rules
158-
from the OwnTS authoring surface — keep one canonical home (the `Own.React`
159-
profile here) and have P-017's ESLint rules reference it, not duplicate the
160-
semantics.
157+
3. **Overlap with P-017's cleanup rules.** `EFF004`/`EFF003`/`EFF005` (timer /
158+
`subscribe` / `AbortController`) restate the OwnTS authoring rules
159+
`OWNTS002`/`003`/`004` — keep one canonical home (the `Own.React` profile here)
160+
and have P-017's ESLint rules reference it, not duplicate the semantics.

0 commit comments

Comments
 (0)