Repository navigation
Commit 2f064dd
committed
fix(audit,cli): Codex review — unbiased sampling, classified group signature, truncation root kind, core-crash report
Four verified findings from the #309 review, all real:
1. Sampling bias (P1): taking the first `sample` instances in
heap-enumeration order could catch only old garbage and miss a later
durably-held instance — a false OBSERVED_ONLY. ALL matching instances
are targeted now: the verdict is exact over the whole population, and
only PATH RESOLUTION is sampled (bounded at `sample` paths).
2. Group signature (P1): grouping by hop type names merged stack-rooted
and durably-rooted instances sharing a type sequence, classifying the
whole group by whichever path came first. The signature now carries
the classification and the per-hop fields.
3. Truncation (P1): stopping the unwind at maxHops yielded
ClrRootKind.None -> 'unsupported-root:None', which the verdict counts
as durable — a long stack-only path read as RETAINED. The parent
chain is now walked to the true root for the verdict; only the
RENDERED path stays bounded.
4. Core-crash report (P2): the rc-70 branch returned exit 5 without
writing ~/.owen/diag/last-failure.json, contradicting the published
contract on the most important internal-error path. It now goes
through CrashReport.Child (null capture — the core's own polite line
is already on stderr), and the gate-A crash smoke asserts the report
is mentioned.
The fifth finding (AGENTS.md: audit development lives in OwnAudit) is a
placement decision answered on the thread: the decoupling half of the
rule is honored (no ownlang coupling, public CLI/JSON only), the witness
core originates from PR #280 which placed it in this repo's audit/, and
the extraction here followed an explicit owner-side direction; whether
to relocate to OwnAudit stays an owner decision, not a drive-by move.
Verified locally: builds clean, selftest 11/11, flagship-demo bad
'leak DEMONSTRATED' / ok 'fix VERIFIED (OBSERVED_ONLY)'.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015de4MezSeUnZBoWq1fFU5M1 parent 3774e5f commit 2f064dd
4 files changed
Lines changed: 36 additions & 10 deletions
File tree
- .github/workflows
- audit/runtime/RetentionPath
- frontend/roslyn/OwnSharp.Cli
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2414 | 2414 | | |
2415 | 2415 | | |
2416 | 2416 | | |
| 2417 | + | |
2417 | 2418 | | |
2418 | 2419 | | |
2419 | 2420 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
123 | 129 | | |
124 | 130 | | |
125 | 131 | | |
126 | 132 | | |
127 | 133 | | |
128 | 134 | | |
129 | 135 | | |
130 | | - | |
| 136 | + | |
131 | 137 | | |
132 | 138 | | |
133 | 139 | | |
| |||
209 | 215 | | |
210 | 216 | | |
211 | 217 | | |
| 218 | + | |
212 | 219 | | |
213 | 220 | | |
214 | 221 | | |
215 | 222 | | |
| 223 | + | |
| 224 | + | |
216 | 225 | | |
217 | 226 | | |
218 | | - | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
219 | 234 | | |
220 | 235 | | |
221 | 236 | | |
| |||
241 | 256 | | |
242 | 257 | | |
243 | 258 | | |
| 259 | + | |
244 | 260 | | |
245 | 261 | | |
246 | 262 | | |
247 | 263 | | |
248 | 264 | | |
249 | | - | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
250 | 276 | | |
251 | 277 | | |
252 | 278 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
142 | 145 | | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
| 146 | + | |
| 147 | + | |
149 | 148 | | |
150 | 149 | | |
151 | 150 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| |||
0 commit comments