Repository navigation
Commit 447dee4
committed
fix(extractor): don't exempt an empty sync Dispose when the type has a real DisposeAsync (#225)
Codex review catch. HasEmptyDisposeBody proved only that the SYNCHRONOUS Dispose()
body is empty; a type implementing both IDisposable and IAsyncDisposable can have
an empty sync Dispose() as a compatibility no-op while DisposeAsync() does the real
cleanup. The flow detector already treats DisposeAsync() as a release, so silencing
such a local would drop a real leak. Now conservatively refuse to exempt any type
that declares its own parameterless DisposeAsync.
Pinned by a new AsyncReader control in EmptyDisposeSample.cs (empty sync Dispose,
real DisposeAsync) — flagged in both the flat and --flow-locals CI jobs; the two
provably-empty-Dispose locals stay silent. Verified locally: existing-sample diff
still byte-identical (the guard only ever flags MORE, never fewer); gates green
(test_ownir 276/276, ruff, mypy).
Refs #225
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cg6DVXahkyY68Ruu7f76rG1 parent 8630b4d commit 447dee4
3 files changed
Lines changed: 41 additions & 4 deletions
File tree
- .github/workflows
- frontend/roslyn
- OwnSharp.Extractor
- samples
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
846 | 846 | | |
847 | 847 | | |
848 | 848 | | |
| 849 | + | |
| 850 | + | |
| 851 | + | |
849 | 852 | | |
850 | 853 | | |
851 | 854 | | |
| |||
1088 | 1091 | | |
1089 | 1092 | | |
1090 | 1093 | | |
1091 | | - | |
1092 | | - | |
| 1094 | + | |
| 1095 | + | |
| 1096 | + | |
| 1097 | + | |
| 1098 | + | |
| 1099 | + | |
1093 | 1100 | | |
1094 | | - | |
1095 | | - | |
| 1101 | + | |
| 1102 | + | |
1096 | 1103 | | |
1097 | 1104 | | |
1098 | 1105 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1324 | 1324 | | |
1325 | 1325 | | |
1326 | 1326 | | |
| 1327 | + | |
| 1328 | + | |
| 1329 | + | |
| 1330 | + | |
| 1331 | + | |
| 1332 | + | |
1327 | 1333 | | |
1328 | 1334 | | |
1329 | 1335 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
61 | 77 | | |
62 | 78 | | |
63 | 79 | | |
| |||
96 | 112 | | |
97 | 113 | | |
98 | 114 | | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
99 | 123 | | |
0 commit comments