Repository navigation
Commit 48e639d
committed
docs(P-022): add the secondary and identity coordinate carriers
Third and last RED before the representation choice. The previous revision of
this inventory stopped at `Diagnostic.line` and spoke as though that were the
coordinate surface. Review found a whole second family in the same crate, and
the omission was not cosmetic: two of its members are identity carriers, where
changing a type is a comparison-key change and not a representation change.
Added: `Evidence.line`, `DiagKey.line`, `EvidenceIdentity.line`,
`DiagIdentity.line`, `LocatedDiagnostic::line()`, and — filed under projection
rather than as semantic carriers — `sarif::Step.line`, `sarif::Region.
start_line`, `sarif::phys`.
The measurement that makes them worth separating: secondary coordinates do NOT
behave like the primary one. Varying the validated `ctor_line` on a DI captive,
and `services[].line` on its flow hop:
ctor_line i64::MIN / -1 / 0 -> related is EMPTY, the location disappears
ctor_line 1 / u32::MAX+1 / i64::MAX -> carried verbatim, past u32::MAX
services[].line i64::MIN / 0 -> the captor hop is DROPPED from the flow
services[].line i64::MAX -> the hop carries the value verbatim
So a secondary coordinate is admission-gated at `>= 1` — `i64::MIN` drops the
hop, so it is the `>= 1` predicate and not a truthiness test, which agree only
at zero — while being unbounded upward exactly like the primary. It needs the
raised ceiling and never sees a non-positive value. The primary
`Diagnostic.line` needs the whole signed band, `0` and negatives included.
Same conflation caught one layer out: `Region.start_line` and `Step.line` are
`u32`, and the reference emits `startLine` at `i64::MAX`. SARIF's narrower
ADMISSION domain (`>= 1`) had been read as a narrower numeric carrier, which
the format does not ask for. It keeps the gate and loses the ceiling.
`column` is explicitly excluded and stays `Option<NonZeroU32>`. Its 1-based
contract is real and column-specific; `line` has none, which is what cp1's
`accept-zero-line` and `accept-negative-line` controls pin. Widening it
alongside `line` because both are "coordinates" would re-glue the two axes
three censuses were spent separating — the exact substitution #250's stop
condition 12 exists to catch.
Refs #250, #259.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CJF7MBi1ijU5m9cJVWgQsM1 parent 57ea57e commit 48e639d
1 file changed
Lines changed: 88 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
40 | 107 | | |
41 | 108 | | |
42 | 109 | | |
| |||
79 | 146 | | |
80 | 147 | | |
81 | 148 | | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
82 | 155 | | |
83 | 156 | | |
84 | 157 | | |
| |||
122 | 195 | | |
123 | 196 | | |
124 | 197 | | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
0 commit comments