Repository navigation
Commit 49294f1
committed
fix(ownts): consume full multi-line expr cleanup; fail CI on ownir crash
Two follow-ups from review (CodeRabbit + Codex) on the cleanup-span fix:
- Expression-bodied cleanups were cut at the FIRST newline after `=>`, so a
formatted cleanup like
return () =>
el.removeEventListener("resize", onResize);
left an empty cleanup and reintroduced the false OWN001. _cleanup_span now
consumes the whole expression across line breaks, stopping only at a top-level
`;` or the effect body's own closing brace (depth-aware over the masked body).
- The silent-case CI step used `|| true`, which would turn an OwnIR load/schema
crash (rc 2, no findings printed) into a false-green zero-count. Dropped it so a
parser/core regression fails the step; the other steps keep `|| true` because
they legitimately expect findings (rc 1).
EffectExprCleanup.tsx gains a multi-line cleanup case. Full suite green
(effects 31/31, ownir 194/194); ruff + mypy --strict clean; all fixtures
unchanged.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PVeuchch67CtjSbizYm8gi1 parent 23c89f2 commit 49294f1
3 files changed
Lines changed: 30 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1092 | 1092 | | |
1093 | 1093 | | |
1094 | 1094 | | |
1095 | | - | |
| 1095 | + | |
| 1096 | + | |
| 1097 | + | |
1096 | 1098 | | |
1097 | 1099 | | |
1098 | 1100 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
14 | 22 | | |
15 | 23 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
395 | 395 | | |
396 | 396 | | |
397 | 397 | | |
398 | | - | |
399 | | - | |
400 | | - | |
401 | | - | |
402 | | - | |
403 | | - | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
404 | 417 | | |
405 | 418 | | |
406 | 419 | | |
| |||
0 commit comments