Repository navigation
Commit 4a0e11c
committed
docs(ownir): retire five doc claims the rewrite left behind
Review raised one of these as a nitpick against `af6e782`. Checking it
against the current tree found four more, all mine, all introduced by
not re-reading doc comments after the architecture changed under them.
* the crate doc still said the ledger was **191** controls; the
seventh category took it to 193. Same number stale in the depth test.
* `Subscription::column` said the check "lives in `OwnIr::validate`".
It lived in `gate_components` when that was written, and both are
gone: it is `strict::column`, reached from `from_json` and
`validate` alike.
* `OwnIr::protocols` was the bad one. It still read "Record-level
validity beyond that is NOT yet mirrored" — the exact claim this PR
retracted. The reference CALLS the obligation parser inside `load()`
and wraps its errors, so it is part of the door, and the second
census measured that supposed boundary as 47 of its 58 permissive
documents. The comment was describing the bug as if it were the
design.
* `OwnIr::protocol_functions` repeated it by reference.
Worth naming: the misleading one was not the one review found. It was
found by grepping for every stale symbol at once — `gate_*`, `191`,
`OwnIr::validate` — rather than fixing the line that was pointed at.
A doc comment that survives the code it documents is the same failure
class as a test that survives the behaviour it asserts; neither gets
re-read just because something near it changed.
Refs #250, #259.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CJF7MBi1ijU5m9cJVWgQsM1 parent 6839a6b commit 4a0e11c
2 files changed
Lines changed: 19 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
294 | 294 | | |
295 | 295 | | |
296 | 296 | | |
297 | | - | |
| 297 | + | |
| 298 | + | |
298 | 299 | | |
299 | 300 | | |
300 | 301 | | |
| |||
528 | 529 | | |
529 | 530 | | |
530 | 531 | | |
531 | | - | |
532 | | - | |
533 | | - | |
534 | | - | |
535 | | - | |
536 | | - | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
537 | 545 | | |
538 | 546 | | |
539 | 547 | | |
540 | 548 | | |
541 | 549 | | |
542 | 550 | | |
543 | | - | |
544 | | - | |
| 551 | + | |
| 552 | + | |
545 | 553 | | |
546 | 554 | | |
547 | 555 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
342 | 342 | | |
343 | 343 | | |
344 | 344 | | |
345 | | - | |
| 345 | + | |
346 | 346 | | |
347 | 347 | | |
348 | 348 | | |
| |||
0 commit comments