You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 57ed39f
Browse filesBrowse the repository at this point in the historyBrowse files
audit(xaml): XAML100 deep signature — capture text + precise x:Key exclusion (review)
Two false-positive fixes from the Codex/CodeRabbit review on PR #128's deep
template signature:
- Capture character data. Node never stored text, so the deep signature treated
<DataTemplate><TextBlock>OK</> and ...Cancel... as identical and XAML100 would
flag text-different templates as duplicates. Added Node.text + an expat
CharacterDataHandler (accumulates across split runs), and the trimmed text is now
part of _deep_resource_sig.
- Make the x:Key exclusion prefix-aware. The signature dropped every attribute whose
local name is "Key", not just the resource directive x:Key — so a descendant CLR
`KeyBinding Key="Enter"` vs "Escape" was erased, collapsing non-identical
templates. _is_xkey now excludes only a prefixed `x:Key`; a bare CLR `Key` stays
in the signature. Attribute names are kept raw (prefix included) for fidelity.
Selftest grows to 42: templates differing only in text are not duplicates (identical
text still collapses); a descendant KeyBinding Key keeps templates distinct.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015zoG4YNCUf7RA5r8GAXMmb
0 commit comments