Repository navigation
Commit 6cc5c52
authored
test(diagnostics): close the rule-4 acceptance gap and three ledger nitpicks (#323)
P-022 rule 4 states two lines as normative acceptance; the executable guard
implemented only the first. This brings the guard up to the norm accepted in
#322, and no further.
_insertion_effect() returns churn / added / removed. Each of the three
mutations is caught by exactly one number, with the other two structurally
blind to it:
seed = sorted index churn=42 added=1 removed=0
iterate the golden's codes churn=0 added=0 removed=0
cap ledger at previous size churn=0 added=1 removed=1
(baseline) churn=0 added=1 removed=0
The third number came from a Codex finding during review: a generator capped at
its previous size emits the probe AND drops an existing code. The dropped
record never enters the churn comparison and the addition still counts one, so
both original numbers read clean while the ledger had not grown at all. This
does not widen rule 4 — a delta is a gain, and counting only additions was
measuring the stated norm wrong.
The churn gate sits behind the staleness check, so it was additionally verified
after regenerating under the mutation, where it fires with its own message.
Three nitpicks from the #321 review, also mutation-checked:
* analyzer_corpus read with expect, matching every other accessor in the file;
dropping the key from one case now fails naming it, where unwrap_or(false)
would have silently under-counted coverage.
* changed == unexplained asserted explicitly, since they move together by
construction and an added explanation channel must split them deliberately.
Recorded honestly: on a green tree this is 0 == 0 and proves nothing. Shown
to have teeth by a compound mutation (corrupt one recorded text so a
divergence exists, drop the unexplained increment) — it fires first, naming
the counter split rather than the divergence.
* every_optional_field_shape_is_still_exercised guards the nine arms the
generator rotates. Collapsing the two-evidence arm and regenerating fails
only this test: the divergence check still passes 47/47, because it asks
whether each case matches its own recorded text, never whether a shape
disappeared.
Test-only; no production code touched on either side.
Refs #255, #250.1 parent 3736ec0 commit 6cc5c52
2 files changed
Lines changed: 186 additions & 25 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
| 11 | + | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
17 | 21 | | |
18 | 22 | | |
19 | 23 | | |
| |||
25 | 29 | | |
26 | 30 | | |
27 | 31 | | |
28 | | - | |
| 32 | + | |
29 | 33 | | |
30 | 34 | | |
31 | 35 | | |
| |||
183 | 187 | | |
184 | 188 | | |
185 | 189 | | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
186 | 213 | | |
187 | 214 | | |
188 | 215 | | |
| |||
195 | 222 | | |
196 | 223 | | |
197 | 224 | | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
198 | 285 | | |
199 | 286 | | |
200 | 287 | | |
| |||
212 | 299 | | |
213 | 300 | | |
214 | 301 | | |
215 | | - | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
216 | 307 | | |
217 | 308 | | |
218 | 309 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
37 | 41 | | |
38 | 42 | | |
39 | 43 | | |
| |||
47 | 51 | | |
48 | 52 | | |
49 | 53 | | |
| 54 | + | |
50 | 55 | | |
51 | 56 | | |
52 | 57 | | |
| |||
218 | 223 | | |
219 | 224 | | |
220 | 225 | | |
221 | | - | |
222 | | - | |
223 | | - | |
224 | | - | |
225 | | - | |
226 | | - | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
227 | 246 | | |
228 | 247 | | |
229 | 248 | | |
230 | 249 | | |
231 | 250 | | |
232 | 251 | | |
233 | | - | |
| 252 | + | |
| 253 | + | |
234 | 254 | | |
235 | 255 | | |
236 | 256 | | |
237 | | - | |
238 | | - | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
239 | 261 | | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
244 | 265 | | |
245 | | - | |
246 | | - | |
247 | | - | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
248 | 310 | | |
249 | 311 | | |
250 | | - | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
251 | 317 | | |
252 | 318 | | |
253 | 319 | | |
254 | 320 | | |
255 | 321 | | |
256 | 322 | | |
257 | | - | |
258 | | - | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
259 | 329 | | |
260 | 330 | | |
261 | 331 | | |
| |||
0 commit comments