You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 7bae944
Browse filesBrowse the repository at this point in the historyBrowse files
> shipped; JSON Schema still pending), N6 ✅ (validation, not a full enum — see
213
+
> below), N9 ✅. N8 re-scoped (not surgical — see note). The rest stand.
214
+
189
215
| # | Item | Where | Why now |
190
216
|---|------|-------|---------|
191
-
| N1 |`else: raise` on unknown flow ops (+ the five walkers) |`ownlang/ownir.py:1692-1836`| Silent fact-swallowing → fabricated/missed verdicts (§2.1) |
192
-
| N2 | Auto-discovery in the test runner |`tests/run_tests.py:1144-1149`| 25-term hand-rolled `or`; a forgotten `rc` silently stops gating |
217
+
| N1 ✅ |`else: raise` on unknown flow ops |`ownlang/ownir.py``_lower_flow`| Silent fact-swallowing → fabricated/missed verdicts (§2.1). *Done: raises `OwnIRError`; pinned by test_ownir. The five read-only walkers legitimately ignore ops they don't consume, so the guard is scoped to `_lower_flow` (the only pass that must handle every op or lose facts).*|
218
+
| N2 ✅ | Auto-discovery in the test runner |`tests/run_tests.py`| 25-term hand-rolled `or`; a forgotten `rc` silently stopped gating. *Done: the runner now globs `test_*.py`, calls each module's `run()`, and gates on `any(rc)` — a new test file is auto-included, a module without `run()` fails the suite, and a discovery of zero modules fails loud. `test_codegen_props` keeps its lighter in-suite iteration count via a small special-case map.*|
193
219
| N3 | Golden facts snapshots in CI + feed to `test_ownir.py`|`ci.yml` wpf-extractor job | The seam is never diffed at the facts level (§2.2) |
194
-
| N4 |`spec/OwnIR.md`+ JSON Schema + evolution policy | new; `ownir.py:1-97` is the source | §2.3–2.4|
220
+
| N4 ◑ |`spec/OwnIR.md`✅ + evolution policy ✅ + version single-sourcing ✅ + JSON Schema (trigger now fired) |`spec/OwnIR.md`, `tests/test_ownir.py`| §2. *Done: normative spec with the version evolution policy (IR1–IR6), registered in `spec/README.md`; and a producer-version-consistency check (each frontend's `ownir_version` must equal the core's). Remaining: `spec/ownir.schema.json` — its trigger has now fired (P-022 #170's `own-ir` crate = a second hand-written type set), so **co-design it with that crate and generate the Rust types from it**, per the §2 box; do NOT bolt a `jsonschema` CI validator onto the zero-dep core first.*|
195
221
| N5 | DI001–005 + EFF001 into `spec/` + `Diagnostics.md` + `test_spec.py`|`ownlang/di.py`, `effects.py`| Second-largest analyzer has zero normative governance |
196
-
| N6 | Diagnostic `Code` enum (replace bare string literals) |`ownlang/diagnostics.py:243` + emit sites | New codes land weekly; a typo'd code silently renders`""`|
222
+
| N6 ✅ | Fail-loud on unknown diagnostic code |`ownlang/diagnostics.py``Diagnostic.__post_init__`| New codes land weekly; a typo'd code silently rendered`""`. *Done: `Diagnostic` now rejects any code absent from `TITLES` at construction (full suite confirms every emitted code is registered), and `title` indexes instead of `.get(...,"")`. A full `StrEnum` is the heavier follow-up; this closes the silent-`""` hole cheaply.*|
197
223
| N7 | Split `ownir.py` → `ownir/{render,load,lower,inference,check}`|`ownlang/ownir.py` (2430 lines) | Fastest-accreting file in the repo; `check_facts` grows a branch per resource kind; deferring = paying the god-file tax on every feature |
198
-
| N8 | Dedicated syntax-error code (stop filing `ParseError` as OWN020) |`ownlang/__main__.py:80`|Miscategorized as "unsupported construct"|
199
-
| N9 | Bare `assert` on the loan invariant → raise |`ownlang/analysis.py:200-203`| Stripped under `python -O`; silent wrong answer if block-scoping is ever relaxed|
| N8 ⚠️ | Dedicated syntax-error code (stop filing `ParseError` as OWN020) |`ownlang/__main__.py:80`|**Re-scoped: not surgical.** OWN020 is the suite-wide code for *any* parse/lex rejection — `for`/`loop`/`async` are lexer-*rejected keywords* (LexError → OWN020 by design), and the corpus/gallery/wpf/rid/loops test helpers all treat OWN020 as "parse rejected". Splitting a genuine syntax error from an unsupported-construct rejection means distinguishing the two at the lexer/parser and updating ~6 test files + `Grammar.md`/`CLI.md`/`OwnCore.md`. A real UX win, but a small refactor, not a one-liner.|
225
+
| N9 ✅ | Bare `assert` on the loan invariant → raise |`ownlang/analysis.py``join()`| Stripped under `python -O`. *Done: mirrors the explicit-raise pattern already used at `_join_handle_rid`, so the invariant holds in every build.*|
226
+
| N10 ✅ | Reconcile/document BCL table asymmetry |`Program.cs``IsOwningFactory` + `ownir.py``_BCL_FRESH_BY_NS`| Lockstep already quietly diverged (§2.6). *Done: documented, not reconciled — because the two are NOT a mirror. `IsOwningFactory` is the emission authority (a match emits an `acquire`), so it is the SUPERSET incl. ADO.NET + network `Accept*`; the bridge table is consulted only for `call`-op results (`_callee_returns_fresh`), and owning factories are emitted as `acquire` not `call`, so it is a deliberate SUBSET — the C#-only entries never arrive as `call`s. Forcing the lists identical would add dead entries; instead the misleading "kept in lockstep" comments on both sides now state the real roles + the safety invariant (owning factory ⇒ `acquire`) + the generate-from-schema exit.*|
0 commit comments