Repository navigation
Commit 957dcb7
committed
docs: Newtonsoft _textWriter is not soundly auto-fixable — shelve the recursive Dispose-no-op idea
Investigated the deferred "recursive Dispose-is-a-no-op" feature against its only
motivating case (Newtonsoft TraceJsonReader._textWriter). Reading the real
JsonTextWriter source settles it: disposal is NOT a no-op type.
- Close() -> base.Close() auto-completes open JSON tokens (writes closing
brackets to the underlying writer), then CloseBufferAndWriter().
- CloseBufferAndWriter() RETURNS the rented _writeBuffer to _arrayPool when an
ArrayPool is configured — a real pooled-buffer release (the POOL-leak class
Own.NET tracks) — and closes the underlying writer.
So a recursive Dispose-no-op recognizer would be unsound (it can leak a pooled
buffer) or would correctly decline — either way it does not clear this finding.
The _textWriter instance is benign only by instance facts (no ArrayPool set + the
sink is a StringWriter), not a type-level no-op — the same reason writers are
excluded from IsNoOpDisposeWrapper. Shelved as not worth building, not deferred.
Sharpened the baseline entry reason and updated no-op-dispose-wrapper.md +
oracle-known-fps.md root-cause #2 with the evidence. No code change. Selftests:
oracle 31/31, corpus 30/30.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019846YSZ35c7CdkWQ1qX5gm1 parent 47c46a6 commit 957dcb7
3 files changed
Lines changed: 45 additions & 27 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
57 | 62 | | |
58 | 63 | | |
59 | 64 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
74 | 83 | | |
75 | 84 | | |
76 | 85 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
189 | 193 | | |
190 | 194 | | |
191 | 195 | | |
| |||
0 commit comments