Repository navigation
Commit 9f909c7
committed
fix(ownir): put the limits in the JSON schema, and stop overclaiming in §4.2
Two review findings on bc8790c, both real, one with a wrong consequence
attached.
**The schema had to carry the bounds too.** `spec/ownir.schema.json` is
what a NON-Python consumer validates against. With the bounds only in
`load()`, a producer could be schema-valid and still refused at the door
— the same cross-consumer mismatch this change exists to remove, one
layer further out. Added `$defs.sourceLine` (signed-64) and a `maximum`
on `sourceColumn`, and rebound all 21 inline `"line": {"type":
"integer"}` fields to it.
The test now asserts the schema's four numbers against the same literals
as the code, so the two cannot drift. Mutation-proved both ways: widening
`sourceLine.maximum` to `2^64-1` and dropping `sourceColumn.maximum` are
each caught.
**§4.2 said "every `line`" and two line-bearing fields escaped it.** The
finding is right that the sentence overclaimed. Its stated consequence —
that this "preserves the Python/port divergence" — is not: measured, both
implementations accept those fields, because neither types them.
python subscription line 2^80 : ACCEPT rust: ACCEPT
python subscription line "x" : ACCEPT rust: ACCEPT
python flow op line 2^80 : ACCEPT rust: ACCEPT
python flow op line "x" : ACCEPT rust: ACCEPT
`components[].subscriptions[].line` and the `line` on a flow op inside
`functions[].body` are checked NOWHERE by `load()` — not for range, and
not even for type. #325's validator has no check for them either (grep
`"line"` in strict.rs: services, effects, bindings, params, sites — not
these two).
So this is not a parity gap, and closing it is not part of removing one.
It is a separate contract question: whether a coordinate no rule reads
should nevertheless have to be well-formed. Extending the check would be
a new restriction on documents accepted today, arriving inside a PR whose
job is to close a measured divergence — so §4.2 now enumerates exactly
the fields it enforces, marks the word "validated" as load-bearing, and
records the two exceptions with the measurement instead of quietly
widening or quietly overclaiming.
Corpus scan for the record: 150 JSON files, zero offenders on either
path, so extending it later would break nothing in the tree.
Refs #250, #259.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CJF7MBi1ijU5m9cJVWgQsM1 parent bc8790c commit 9f909c7
3 files changed
Lines changed: 66 additions & 25 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
182 | 182 | | |
183 | 183 | | |
184 | 184 | | |
185 | | - | |
186 | | - | |
187 | | - | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
188 | 189 | | |
189 | 190 | | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
190 | 202 | | |
191 | 203 | | |
192 | 204 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
53 | 60 | | |
54 | 61 | | |
55 | 62 | | |
| |||
82 | 89 | | |
83 | 90 | | |
84 | 91 | | |
85 | | - | |
| 92 | + | |
86 | 93 | | |
87 | 94 | | |
88 | 95 | | |
| |||
101 | 108 | | |
102 | 109 | | |
103 | 110 | | |
104 | | - | |
| 111 | + | |
105 | 112 | | |
106 | 113 | | |
107 | 114 | | |
| |||
168 | 175 | | |
169 | 176 | | |
170 | 177 | | |
171 | | - | |
| 178 | + | |
172 | 179 | | |
173 | 180 | | |
174 | 181 | | |
| |||
183 | 190 | | |
184 | 191 | | |
185 | 192 | | |
186 | | - | |
| 193 | + | |
187 | 194 | | |
188 | 195 | | |
189 | 196 | | |
| |||
195 | 202 | | |
196 | 203 | | |
197 | 204 | | |
198 | | - | |
| 205 | + | |
199 | 206 | | |
200 | 207 | | |
201 | 208 | | |
| |||
206 | 213 | | |
207 | 214 | | |
208 | 215 | | |
209 | | - | |
| 216 | + | |
210 | 217 | | |
211 | 218 | | |
212 | 219 | | |
| |||
217 | 224 | | |
218 | 225 | | |
219 | 226 | | |
220 | | - | |
| 227 | + | |
221 | 228 | | |
222 | 229 | | |
223 | 230 | | |
| |||
228 | 235 | | |
229 | 236 | | |
230 | 237 | | |
231 | | - | |
| 238 | + | |
232 | 239 | | |
233 | 240 | | |
234 | 241 | | |
| |||
239 | 246 | | |
240 | 247 | | |
241 | 248 | | |
242 | | - | |
| 249 | + | |
243 | 250 | | |
244 | 251 | | |
245 | 252 | | |
| |||
251 | 258 | | |
252 | 259 | | |
253 | 260 | | |
254 | | - | |
| 261 | + | |
255 | 262 | | |
256 | 263 | | |
257 | 264 | | |
| |||
265 | 272 | | |
266 | 273 | | |
267 | 274 | | |
268 | | - | |
| 275 | + | |
269 | 276 | | |
270 | 277 | | |
271 | 278 | | |
| |||
277 | 284 | | |
278 | 285 | | |
279 | 286 | | |
280 | | - | |
| 287 | + | |
281 | 288 | | |
282 | 289 | | |
283 | 290 | | |
| |||
295 | 302 | | |
296 | 303 | | |
297 | 304 | | |
298 | | - | |
| 305 | + | |
299 | 306 | | |
300 | 307 | | |
301 | 308 | | |
| |||
311 | 318 | | |
312 | 319 | | |
313 | 320 | | |
314 | | - | |
| 321 | + | |
315 | 322 | | |
316 | 323 | | |
317 | 324 | | |
| |||
333 | 340 | | |
334 | 341 | | |
335 | 342 | | |
336 | | - | |
| 343 | + | |
337 | 344 | | |
338 | 345 | | |
339 | 346 | | |
| |||
420 | 427 | | |
421 | 428 | | |
422 | 429 | | |
423 | | - | |
| 430 | + | |
424 | 431 | | |
425 | 432 | | |
426 | 433 | | |
| |||
431 | 438 | | |
432 | 439 | | |
433 | 440 | | |
434 | | - | |
| 441 | + | |
435 | 442 | | |
436 | 443 | | |
437 | 444 | | |
| |||
440 | 447 | | |
441 | 448 | | |
442 | 449 | | |
443 | | - | |
| 450 | + | |
444 | 451 | | |
445 | 452 | | |
446 | 453 | | |
| |||
449 | 456 | | |
450 | 457 | | |
451 | 458 | | |
452 | | - | |
| 459 | + | |
453 | 460 | | |
454 | 461 | | |
455 | 462 | | |
| |||
458 | 465 | | |
459 | 466 | | |
460 | 467 | | |
461 | | - | |
| 468 | + | |
462 | 469 | | |
463 | 470 | | |
464 | 471 | | |
| |||
469 | 476 | | |
470 | 477 | | |
471 | 478 | | |
472 | | - | |
| 479 | + | |
473 | 480 | | |
474 | 481 | | |
475 | 482 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
162 | 184 | | |
163 | 185 | | |
164 | 186 | | |
| |||
0 commit comments