Commit 68fb36a
fix(intercom): expose manage-conversation options as static props for MCP v3 (#21753)
* fix(intercom): expose manage-conversation options as static props for MCP v3
`Manage A Conversation` revealed `type`, `assigneeId`, `teamAssigneeId`, `body`
and `snoozedUntil` through `additionalProps()`, driven by `reloadProps` on
`messageType` and `type`. An MCP tool resolves its JSON Schema once at
registration, so props that only appear after a parent prop is set never reach
an agent.
As the issue notes, this action fetches nothing: `additionalProps()` only
flipped `hidden` on props that were already declared, then returned `{}`. All
five are now declared plainly and the mechanism is gone.
Three of them -- `type`, `assigneeId` and `teamAssigneeId` -- were hidden but
not marked optional, so simply unhiding them would have made them required and
broken every existing configuration. They are now explicitly `optional: true`.
`body` and `snoozedUntil` were already optional. Nothing became required and no
default changed.
Since the form no longer hides the props that do not apply, each description now
says which `messageType` it belongs to, and the action description lists the
mapping. That is also what an agent reads to call the tool correctly.
Also fixes a bug this mechanism was hiding: `run()` never read
`teamAssigneeId`. Assigning to a team set `type: "team"` and then sent
`assignee_id: assigneeId`, which `additionalProps()` had just hidden and left
undefined -- so team assignment silently sent no assignee at all. `assignee_id`
now takes the team id when `type` is `team`. The two ids stay separate props
because they list different options (admins vs teams).
* fix(intercom): add a concrete ISO 8601 example to the snoozedUntil description
Date prop descriptions must carry a concrete inline example, per the component
guidelines. The format string is replaced with a real timestamp.
* fixing the coderabbit review and changes related to manage conversation
---------
Co-authored-by: vetrivigneshwaran <vicky@pipedream.com>1 parent 099e61a commit 68fb36a
2 files changed
Lines changed: 48 additions & 52 deletions
Lines changed: 47 additions & 51 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
1 | 2 | | |
2 | 3 | | |
3 | 4 | | |
| |||
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
10 | | - | |
11 | | - | |
| 11 | + | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
29 | | - | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | 33 | | |
42 | 34 | | |
43 | 35 | | |
44 | 36 | | |
45 | 37 | | |
46 | 38 | | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
47 | 46 | | |
48 | 47 | | |
49 | 48 | | |
50 | 49 | | |
51 | 50 | | |
52 | 51 | | |
53 | | - | |
54 | | - | |
| 52 | + | |
| 53 | + | |
55 | 54 | | |
56 | 55 | | |
57 | 56 | | |
58 | 57 | | |
59 | 58 | | |
60 | 59 | | |
61 | | - | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
62 | 63 | | |
63 | 64 | | |
64 | 65 | | |
65 | 66 | | |
66 | | - | |
67 | | - | |
| 67 | + | |
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
74 | | - | |
| 73 | + | |
75 | 74 | | |
76 | 75 | | |
77 | 76 | | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | 77 | | |
108 | 78 | | |
109 | 79 | | |
| |||
125 | 95 | | |
126 | 96 | | |
127 | 97 | | |
| 98 | + | |
128 | 99 | | |
129 | 100 | | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
130 | 122 | | |
131 | 123 | | |
132 | 124 | | |
| |||
137 | 129 | | |
138 | 130 | | |
139 | 131 | | |
140 | | - | |
141 | | - | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
142 | 138 | | |
143 | 139 | | |
144 | 140 | | |
145 | | - | |
| 141 | + | |
146 | 142 | | |
147 | 143 | | |
148 | 144 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
0 commit comments