config: inline toString() (more or less)

for string, numbers and boolean it's the same behaviour; now it could
stringify other types that before were yielding only "", but shouldn't
matter much here.  Also, no need to special case strings since it's not
a performance-sensitive part, and the gained readability matters.

Author: omar-polo

config/load_test.go

@@ -277,10 +277,10 @@ remote:
 		t.Fatalf("location = %q", got["remote"]["location"])
 	}
 	if got["remote"]["port"] != "22" {
-		t.Fatalf("port = %q (toString should convert int)", got["remote"]["port"])
+		t.Fatalf("port = %q (should be converted from int)", got["remote"]["port"])
 	}
 	if got["remote"]["ssl"] != "true" {
-		t.Fatalf("ssl = %q (toString should convert bool)", got["remote"]["ssl"])
+		t.Fatalf("ssl = %q (should be converted from bool)", got["remote"]["ssl"])
 	}
 }
 
@@ -322,27 +322,6 @@ func TestLoadJSONBad(t *testing.T) {
 	}
 }
 
-func TestToString(t *testing.T) {
-	cases := []struct {
-		in   any
-		want string
-	}{
-		{"hello", "hello"},
-		{42, "42"},
-		{int64(7), "7"},
-		{3.14, "3.14"},
-		{true, "true"},
-		{false, "false"},
-		{nil, ""},
-		{[]int{1, 2}, ""},
-	}
-	for _, c := range cases {
-		if got := toString(c.in); got != c.want {
-			t.Errorf("toString(%v) = %q, want %q", c.in, got, c.want)
-		}
-	}
-}
-
 func TestLoadFileYAMLWithLocation(t *testing.T) {
 	rd := strings.NewReader(`
 remote:

config/loadfile.go

@@ -12,17 +12,6 @@ import (
 	"go.yaml.in/yaml/v3"
 )
 
-func toString(v any) string {
-	switch t := v.(type) {
-	case string:
-		return t
-	case int, int64, float64, bool:
-		return fmt.Sprintf("%v", t)
-	default:
-		return ""
-	}
-}
-
 func loadINI(rd io.Reader) (map[string]map[string]string, error) {
 	cfg, err := ini.Load(rd)
 	if err != nil {
@@ -60,7 +49,7 @@ func loadYAML(rd io.Reader) (map[string]map[string]string, error) {
 		}
 		result[section] = make(map[string]string)
 		for k, v := range sectionMap {
-			result[section][k] = toString(v)
+			result[section][k] = fmt.Sprint(v)
 		}
 	}