introduce a helper for yaml.NewEncoder() to always close it

[omar-polo]

unlike json.NewEncoder(), yaml Encoder needs to be Close()d to properly flush. Introduce an helper and use it across the codebase to avoid forgetting to do so.

[Copilot]

Pull request overview

This PR introduces a small YAML marshaling helper to ensure yaml.Encoder is always Close()d (to properly flush), and updates call sites to use it so YAML output isn’t silently truncated due to a missed close.

Changes:

• Added utils.YAMLEncode(io.Writer, any) error as a single safe entry point for YAML encoding + encoder close.
• Replaced direct yaml.NewEncoder(...).Encode(...) usage with YAMLEncode(...) in config saving and CLI output paths.
• Updated imports in affected files to remove direct YAML encoder usage and reference utils instead.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
utils/marshal.go	Adds YAMLEncode helper that encodes and closes the YAML encoder.
utils/config_policy.go	Uses YAMLEncode for policy config persistence and YAML dumps.
subcommands/service/show.go	Uses utils.YAMLEncode for YAML output of service configuration.
subcommands/config/config.go	Uses utils.YAMLEncode for YAML output in config store show path.
config/load.go	Uses utils.YAMLEncode when writing config YAML files to disk.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[omar-polo]

this is still marked as draft as it depends on #2095 to go in first.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

config/load.go:168

• tmpFile.Close() errors are ignored. If the close fails (e.g., delayed write/FS error), the code may still proceed as if the YAML write succeeded and (in the success path) rename an incompletely flushed file. Capture the close error and treat it like an encode failure before renaming.

	err = utils.YAMLEncode(tmpFile, src)
	tmpFile.Close()

	if err == nil {
		err = os.Rename(tmpFile.Name(), file)

utils/config_policy.go:211

• tmpFile.Close() errors are ignored. If the close fails, the file may not be fully flushed but the code can still rename it, producing a partial/corrupted policy file. Capture the close error and treat it like an encode failure before renaming.

	err = YAMLEncode(tmpFile, c)
	tmpFile.Close()
	if err == nil {
		err = os.Rename(tmpFile.Name(), filename)
	}