Skip to content

Add custom loader/deserializer, drop field_map from filedrop module - #109

Merged
arhamchopra merged 2 commits into
mainfrom
ac/filedrop
Aug 4, 2025
Merged

Add custom loader/deserializer, drop field_map from filedrop module#109
arhamchopra merged 2 commits into
mainfrom
ac/filedrop

Conversation

@arhamchopra

Copy link
Copy Markdown
Collaborator

This PR adds custom loaders and deserializer to the filedrop module.
In addition, it removes support for field_maps in the module since the custom loaders and deserializers can provide more flexibility.

Signed-off-by: Arham Chopra <arham.chopra@cubistsystematic.com>
@github-actions

github-actions Bot commented Aug 2, 2025

Copy link
Copy Markdown
Contributor

Test Results

369 tests  +5   369 ✅ +5   6m 16s ⏱️ + 2m 22s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit dd552de. ± Comparison against base commit 6bf61c0.

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Aug 2, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.82540% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.15%. Comparing base (6bf61c0) to head (dd552de).
⚠️ Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
csp_gateway/server/modules/filedrop/filedrop.py 78.94% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   90.12%   90.15%   +0.02%     
==========================================
  Files         121      121              
  Lines       10091    10141      +50     
==========================================
+ Hits         9095     9143      +48     
- Misses        996      998       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arhamchopra
arhamchopra marked this pull request as ready for review August 2, 2025 04:09
timkpaine
timkpaine previously approved these changes Aug 2, 2025
Signed-off-by: Arham Chopra <arham.chopra@cubistsystematic.com>
@arhamchopra
arhamchopra merged commit 56acba2 into main Aug 4, 2025
12 checks passed
@arhamchopra
arhamchopra deleted the ac/filedrop branch August 4, 2025 21:25
@timkpaine timkpaine added the type: enhancement Minor improvements label Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement Minor improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants