Add custom loader/deserializer, drop field_map from filedrop module - #109
Merged
Conversation
Signed-off-by: Arham Chopra <arham.chopra@cubistsystematic.com>
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 90.12% 90.15% +0.02%
==========================================
Files 121 121
Lines 10091 10141 +50
==========================================
+ Hits 9095 9143 +48
- Misses 996 998 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arhamchopra
marked this pull request as ready for review
August 2, 2025 04:09
arhamchopra
requested review from
NeejWeej,
emilybarrettp72,
feussy,
hintse,
ptomecek,
timkpaine and
vstolin
as code owners
August 2, 2025 04:09
timkpaine
previously approved these changes
Aug 2, 2025
Signed-off-by: Arham Chopra <arham.chopra@cubistsystematic.com>
timkpaine
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds custom loaders and deserializer to the filedrop module.
In addition, it removes support for field_maps in the module since the custom loaders and deserializers can provide more flexibility.