Skip to content

Take list of configs as input in ReadFileDrop module instead of mapping - #111

Merged
arhamchopra merged 1 commit into
mainfrom
ac/filedrop
Aug 7, 2025
Merged

Take list of configs as input in ReadFileDrop module instead of mapping#111
arhamchopra merged 1 commit into
mainfrom
ac/filedrop

Conversation

@arhamchopra

Copy link
Copy Markdown
Collaborator

No description provided.

@arhamchopra arhamchopra changed the title Take list of configs as input in ReadFileDrop Module instead of mapping Take list of configs as input in ReadFileDrop module instead of mapping Aug 7, 2025
@github-actions

github-actions Bot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

Test Results

370 tests  +1   370 ✅ +1   6m 15s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 4141b11. ± Comparison against base commit 56acba2.

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Aug 7, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.44444% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.21%. Comparing base (dd552de) to head (4141b11).
⚠️ Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
csp_gateway/server/modules/filedrop/filedrop.py 93.10% 2 Missing ⚠️
...way/tests/server/modules/filedrop/test_filedrop.py 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   90.15%   90.21%   +0.05%     
==========================================
  Files         121      121              
  Lines       10141    10161      +20     
==========================================
+ Hits         9143     9167      +24     
+ Misses        998      994       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Arham Chopra <arham.chopra@cubistsystematic.com>
@arhamchopra
arhamchopra merged commit 33f2f01 into main Aug 7, 2025
12 checks passed
@arhamchopra
arhamchopra deleted the ac/filedrop branch August 7, 2025 17:34
@timkpaine timkpaine added type: enhancement Minor improvements component: modules PRs or issues related to the specific modules labels Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: modules PRs or issues related to the specific modules type: enhancement Minor improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants