Skip to content

Support CSP IntEnum compatibility - #322

Merged
timkpaine merged 4 commits into
mainfrom
investigate/csp-pr743-intenum-compat-v3
Aug 25, 2026
Merged

Support CSP IntEnum compatibility#322
timkpaine merged 4 commits into
mainfrom
investigate/csp-pr743-intenum-compat-v3

Conversation

@malhotrashivam

@malhotrashivam malhotrashivam commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Validation:

  • make lint
  • make test: 860 passed, 1 xfailed

Signed-off-by: Shivam Malhotra <shivam.malhotra@cubistsystematic.com>
Signed-off-by: Shivam Malhotra <shivam.malhotra@cubistsystematic.com>
@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Test Results

854 tests  +12   844 ✅ +12   7m 26s ⏱️ -1s
  1 suites ± 0    10 💤 ± 0 
  1 files   ± 0     0 ❌ ± 0 

Results for commit d0f2ba6. ± Comparison against base commit 5f9168a.

This pull request removes 1 and adds 13 tests. Note that renamed tests count towards both.
csp_gateway.tests.config.test_load ‑ test_spaday_demo_configs_load
csp_gateway.tests.config.test_load ‑ test_legacy_demo_config_loads
csp_gateway.tests.server.gateway.csp.test_channels ‑ test_csp_enum_dict_basket_has_static_keys
csp_gateway.tests.server.modules.io.test_json_converter ‑ test_create_snapshot_dict_with_zero_valued_enum_key
csp_gateway.tests.server.web.test_spaday_ui.TestDarkBoot ‑ test_dark_choice_persists_across_reloads
csp_gateway.tests.server.web.test_spaday_ui.TestDarkBoot ‑ test_dark_seed_is_client_evaluated
csp_gateway.tests.server.web.test_spaday_ui.TestDefaultLayout ‑ test_custom_default_layout_replaces_generated_layout
csp_gateway.tests.server.web.test_spaday_ui.TestDefaultLayout ‑ test_schema_without_timestamp_or_id_stays_bare
csp_gateway.tests.server.web.test_spaday_ui.TestDefaultLayout ‑ test_schemas_add_legacy_parity_sort_and_columns
csp_gateway.tests.server.web.test_spaday_ui.TestSpadayPerspectiveLayoutActions ‑ test_layout_action_script_is_served
csp_gateway.tests.server.web.test_spaday_ui.TestSpadayPerspectiveLayoutActions ‑ test_layout_actions_are_available_without_server_layouts
…

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.61%. Comparing base (5f9168a) to head (d0f2ba6).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
csp_gateway/testing/harness.py 40.00% 6 Missing ⚠️
csp_gateway/server/gateway/csp/channels.py 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
+ Coverage   86.47%   86.61%   +0.14%     
==========================================
  Files         156      156              
  Lines       18276    18445     +169     
  Branches     1738     1744       +6     
==========================================
+ Hits        15805    15977     +172     
+ Misses       2471     2468       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timkpaine
timkpaine merged commit 9e50fec into main Aug 25, 2026
10 checks passed
@timkpaine
timkpaine deleted the investigate/csp-pr743-intenum-compat-v3 branch August 25, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants