Restore CSP enum basket compatibility - #334
Closed
timkpaine wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
timkpaine
requested review from
arhamchopra,
emilybarrettp72,
feussy,
hintse,
ptomecek and
vstolin
as code owners
August 25, 2026 14:46
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
==========================================
- Coverage 86.60% 86.59% -0.01%
==========================================
Files 156 156
Lines 18410 18428 +18
Branches 1742 1744 +2
==========================================
+ Hits 15944 15958 +14
- Misses 2465 2468 +3
- Partials 1 2 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Superseded by #322; the compatibility changes were integrated into that branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
csp-gateway 2.9 changed static dict-basket key detection to Python
enum.Enum, which dropped keys for existingcsp.Enumchannel baskets. This restores support for both enum families.Also updates
GatewayTestHarnessunset assertions to use PydanticGatewayStructfield-presence semantics instead ofhasattr(), including indexed list assertions.Validation:
make lint